Skip to content

Not adding "Text Match" in Auto-Segment And Refine generates broken syntax #1119

@jtreminio

Description

@jtreminio

Expected Behavior

If you leave "Text Match" empty in the Segment popup what's inserted is:

<segment:,0.6,0.5>

I didn't catch this at first, and when I tried to view the ComfyUI workflow it generated a broken thing:

Image

Will want to add validation:

  1. prevent clicking "add" button unless required fields are populated, or
  2. do not add to prompt unless required fields are populated, or
  3. have a default value in the "Text Match" text field

Additionally, add something to the UI that flags a field as required (Bootstrap has something, or can just use * character)

Actual Behavior

When "Text Match" is left blank, ComfyUI generates a broken workflow.

Steps to Reproduce

Click "Auto Segment Refinement", then click "add" button. See broken prompt:

<segment:,0.6,0.5>

Debug Logs

None necessary

Other

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't workingEasy PRWant to contribute? Here's a good thing to try

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions