Added PathExtension.TryGetFullyQualifiedPath.

Author: kike-garbo

src/RhinoInside.Revit.External/Extensions/System.IO.cs

@@ -3,9 +3,63 @@
 
 namespace System.IO
 {
-#pragma warning disable CA1060 // Move pinvokes to native methods class
   static class PathExtension
   {
+    internal static readonly StringComparer Comparer = new PathComparer();
+
+    private class PathComparer : StringComparer
+    {
+      private static readonly StringComparer StringComparer = OrdinalIgnoreCase;
+
+      public PathComparer() { }
+
+      private static string Normalize(string path) => Path.GetFullPath(path);
+
+      internal static string Canonicalize(string path) => new FileInfo(path).FullName;
+
+      public override int Compare(string x, string y)
+      {
+        var comparison = StringComparer.Compare(x, y);
+        if (comparison == 0) return 0;
+
+        try
+        {
+          if (StringComparer.Compare(Normalize(x), Normalize(y)) == 0) return 0;
+          return StringComparer.Compare(Canonicalize(x), Canonicalize(y));
+        }
+        catch { return comparison; }
+      }
+
+      public override bool Equals(string x, string y)
+      {
+        if (StringComparer.Equals(x, y)) return true;
+        try
+        {
+          if (StringComparer.Equals(Normalize(x), Normalize(y))) return true;
+          return StringComparer.Equals(Canonicalize(x), Canonicalize(y));
+        }
+        catch { return false; }
+      }
+
+      public override int GetHashCode(string obj)
+      {
+        try { return obj is null ? 0 : StringComparer.GetHashCode(Canonicalize(obj)); }
+        catch { return int.MinValue; }
+      }
+    }
+
+    public static bool TryGetFullyQualifiedPath(ref string path)
+    {
+      if (string.IsNullOrWhiteSpace(path)) return false;
+      if (!IsFullyQualifiedPath(path)) return false;
+      try
+      {
+        path = PathComparer.Canonicalize(path);
+        return true;
+      }
+      catch { return false; }
+    }
+
     public static bool IsFullyQualifiedPath(this string path)
     {
       if (path == null) return false;
@@ -29,17 +83,20 @@ public static bool IsFullyQualifiedPath(this string path)
 #endif
     }
 
-    [DllImport("SHLWAPI", CharSet = CharSet.Unicode)]
-    static extern bool PathCompactPathExW([Out] Text.StringBuilder pszOut, string szPath, int cchMax, int dwFlags);
     internal static string TripleDotPath(this string path, int maxLength)
     {
       if (path is null) return null;
       var builder = new Text.StringBuilder(maxLength + 1);
-      PathCompactPathExW(builder, path, maxLength, 0);
+      SafeNativeMethods.PathCompactPathExW(builder, path, maxLength, 0);
       return builder.ToString();
     }
+
+    static class SafeNativeMethods
+    {
+      [DllImport("SHLWAPI", CharSet = CharSet.Unicode)]
+      public static extern bool PathCompactPathExW([Out] Text.StringBuilder pszOut, string szPath, int cchMax, int dwFlags);
+    }
   }
-#pragma warning restore CA1060 // Move pinvokes to native methods class
 
   internal static class DirectoryInfoExtension
   {

src/RhinoInside.Revit.GH/Components/Documents/DocumentSave.cs

@@ -18,7 +18,7 @@ public class DocumentSave : ZuiComponent
     public DocumentSave() : base
     (
       name: "Save Document",
-      nickname: "Save",
+      nickname: "D-Save",
       description: "Saves a document to a given file path",
       category: "Revit",
       subCategory: "Document"
@@ -104,7 +104,7 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
           if (filePath.Last() == Path.DirectorySeparatorChar)
             filePath = Path.Combine(filePath, doc.Title);
 
-          if (filePath.IsFullyQualifiedPath())
+          if (PathExtension.TryGetFullyQualifiedPath(ref filePath))
           {
             if (!Path.HasExtension(filePath))
             {

src/RhinoInside.Revit.GH/Components/Family/New.cs

@@ -650,7 +650,7 @@ static string GetDefaultTemplatePath(ARDB.Document doc, ARDB.ElementId categoryI
 
     static bool FindTemplatePath(ARDB.Document doc, ref string templatePath, out bool pathWasRelative)
     {
-      pathWasRelative = !templatePath.IsFullyQualifiedPath();
+      pathWasRelative = !PathExtension.TryGetFullyQualifiedPath(ref templatePath);
 
       // Validate input
       foreach (var invalid in Path.GetInvalidPathChars())

src/RhinoInside.Revit.GH/Components/Family/Save.cs

@@ -126,7 +126,7 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
       if (!Path.HasExtension(filePath))
         filePath += ".rfa";
 
-      if (!filePath.IsFullyQualifiedPath())
+      if (!PathExtension.TryGetFullyQualifiedPath(ref filePath))
       {
         filePath = Path.Combine(Types.Document.FromValue(family.Document).SwapFolder.Directory.FullName, "Families", filePath);
         Directory.CreateDirectory(Path.GetDirectoryName(filePath));

src/RhinoInside.Revit.GH/Components/Import/IFCImportOptions.cs

@@ -6,17 +6,17 @@
 namespace RhinoInside.Revit.GH.Components.Insert
 {
   [ComponentVersion(introduced: "1.36")]
-  public class IFCImportOptions : ZuiComponent
+  public class IFCReadOptions : ZuiComponent
   {
     public override Guid ComponentGuid => new Guid("A8F3E5C1-9D4B-4E2A-B8F1-3C5D6E7F8A9B");
     public override GH_Exposure Exposure => GH_Exposure.secondary;
     protected override string IconTag => string.Empty;
 
-    public IFCImportOptions() : base
+    public IFCReadOptions() : base
     (
-      name: "IFC Import Options",
-      nickname: "IFCOpt",
-      description: "Configure options for IFC file import or link operations",
+      name: "IFC Read Options",
+      nickname: "IFC-Read",
+      description: "Configure options to read IFC files.",
       category: "Revit",
       subCategory: "Insert"
     )
@@ -128,7 +128,7 @@ public IFCImportOptions() : base
           NickName = "AC",
           Description = "Autocorrect off-axis lines enabled",
           Access = GH_ParamAccess.item
-        }
+        }, ParamRelevance.Secondary
       )
     };
 
@@ -162,10 +162,10 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
 
       if (options != null)
       {
-        DA.SetData("Intent", (int)options.Intent);
-        DA.SetData("Action", (int)options.Action);
-        DA.SetData("Auto Join", options.AutoJoin);
-        DA.SetData("Autocorrect Off Axis Lines", options.AutocorrectOffAxisLines);
+        Params.TrySetData(DA, "Intent", () => (int)options.Intent);
+        Params.TrySetData(DA, "Action", () => (int)options.Action);
+        Params.TrySetData(DA, "Auto Join", () => options.AutoJoin);
+        Params.TrySetData(DA, "Autocorrect Off Axis Lines", () => options.AutocorrectOffAxisLines);
       }
     }
   }

src/RhinoInside.Revit.GH/Components/Views/ExportImage.cs

@@ -277,7 +277,7 @@ protected override void TrySolveInstance(IGH_DataAccess DA)
         if (folder?.Any(x => Path.GetInvalidPathChars().Contains(x)) is true)
           throw new Exceptions.RuntimeArgumentException("Folder", $"'{folder}' is not a valid folder name", folder);
 
-        if (folder?.IsFullyQualifiedPath() is false)
+        if (!PathExtension.TryGetFullyQualifiedPath(ref folder))
           throw new Exceptions.RuntimeArgumentException("Folder", $"'{folder}' is not a valid absolute path", folder);
       }