Update LUDecomp constructor to properly inherit from Matrix.

Author: mcordingley

src/LUDecomposition.php

@@ -21,18 +21,12 @@ final class LUDecomposition extends Matrix
     protected $permutations = []; // Stores a vector representation of the row permutations performed on this matrix.
 
     /**
-     * @param Matrix $matrix The matrix to decompose.
+     * @param array $literal The matrix to decompose.
      * @throws MatrixException
      */
-    public function __construct(Matrix $matrix)
+    public function __construct(array $literal)
     {
-        // Copy the matrix
-        $matrix->map(function ($element, $i, $j) {
-            $this->internal[$i][$j] = $element;
-        });
-
-        $this->rowCount = $matrix->rows;
-        $this->columnCount = $matrix->columns;
+        parent::__construct($literal);
 
         if (!$this->isSquare()) {
             throw new MatrixException("Matrix is not square.");

src/Matrix.php

@@ -652,7 +652,7 @@ protected function choleskyInverse()
     protected function getLUDecomp()
     {
         if (!$this->LU) {
-            $this->LU = new LUDecomposition($this);
+            $this->LU = new LUDecomposition($this->internal);
         }
 
         return $this->LU;

tests/LUDecompTest.php

@@ -22,23 +22,23 @@ public function testNonSquare()
     {
         static::setExpectedException(MatrixException::class);
 
-        new LUDecomposition(new Matrix([[1, 2, 3]]));
+        new LUDecomposition([[1, 2, 3]]);
     }
 
     public function testSingularByZeroes()
     {
         static::setExpectedException(MatrixException::class);
 
-        new LUDecomposition(new Matrix([
+        new LUDecomposition([
             [0, 0],
             [0, 0],
-        ]));
+        ]);
     }
 
     public function testWrongSizeKnowns()
     {
         $matrix = $this->buildMatrix();
-        $decomp = new LUDecomposition($matrix);
+        $decomp = new LUDecomposition($matrix->toArray());
 
         static::setExpectedException(MatrixException::class);
 
@@ -49,18 +49,18 @@ public function testSingularByDiagonal()
     {
         static::setExpectedException(MatrixException::class);
 
-        new LUDecomposition(new Matrix([
+        new LUDecomposition([
             [1, -1, 2],
             [1, 0, 1],
             [2, 3, -1],
-        ]));
+        ]);
     }
 
     public function testLUDecompConstructor()
     {
         $matrix = $this->buildMatrix();
 
-        $LU = new LUDecomposition($matrix);
+        $LU = new LUDecomposition($matrix->toArray());
 
         $this->assertEquals(1, $LU->get(0, 0));
         $this->assertEquals(-1, $LU->get(0, 1));
@@ -77,7 +77,7 @@ public function testDeterminant()
     {
         $matrix = $this->buildMatrix();
 
-        $LU = new LUDecomposition($matrix);
+        $LU = new LUDecomposition($matrix->toArray());
 
         $this->assertEquals(5, $LU->determinant());
     }
@@ -90,7 +90,7 @@ public function testSolve()
             [1, -1, 4],
         ]);
 
-        $LU = new LUDecomposition($matrix);
+        $LU = new LUDecomposition($matrix->toArray());
 
         $b = [1, 9, 8];
 
@@ -107,7 +107,7 @@ public function testSolve()
             [-2, -3, 4, 4],
         ]);
 
-        $LU = new LUDecomposition($matrix);
+        $LU = new LUDecomposition($matrix->toArray());
 
         $b = [-1, 7, -24, 3];
 
@@ -125,7 +125,7 @@ public function testInverse()
     {
         $matrix = $this->buildMatrix();
 
-        $LU = new LUDecomposition($matrix);
+        $LU = new LUDecomposition($matrix->toArray());
 
         $inverse = $LU->inverse();