Commit c8ac60a
committed
fix(pack): print the compiler's output when the packer's build fails
Windows CI reported
error: build failed
FAIL: shared pack failed off ELF
and nothing else, because `mcpp pack` printed `BuildError::message` and dropped
`BuildError::diagnosticOutput` — the field that carries what the compiler
actually said. `mcpp build` has printed it all along; the two pack pipelines
were the only callers that did not.
That is a defect on its own terms, not just an inconvenience for this
investigation: a packaging failure is exactly when a maintainer has least context,
and three words is not a report. Both pipelines now print it.1 parent bbf785e commit c8ac60a
2 files changed
Lines changed: 21 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
17 | 24 | | |
18 | 25 | | |
19 | 26 | | |
| |||
158 | 165 | | |
159 | 166 | | |
160 | 167 | | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
161 | 176 | | |
162 | 177 | | |
163 | 178 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
89 | 95 | | |
90 | 96 | | |
91 | 97 | | |
| |||
0 commit comments