Skip to content

Commit c033b71

Browse files
nordicjmde-nordic
authored andcommitted
boot: zephyr: Remove reference to old Kconfigs
These Kconfigs are very old and have not existed for a long time, remove them Signed-off-by: Jamie McCrae <[email protected]>
1 parent 268968f commit c033b71

File tree

2 files changed

+9
-28
lines changed

2 files changed

+9
-28
lines changed

boot/zephyr/main.c

Lines changed: 8 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -90,22 +90,8 @@ const struct boot_uart_funcs boot_funcs = {
9090
#include <arm_cleanup.h>
9191
#endif
9292

93-
/* CONFIG_LOG_MINIMAL is the legacy Kconfig property,
94-
* replaced by CONFIG_LOG_MODE_MINIMAL.
95-
*/
96-
#if (defined(CONFIG_LOG_MODE_MINIMAL) || defined(CONFIG_LOG_MINIMAL))
97-
#define ZEPHYR_LOG_MODE_MINIMAL 1
98-
#endif
99-
100-
/* CONFIG_LOG_IMMEDIATE is the legacy Kconfig property,
101-
* replaced by CONFIG_LOG_MODE_IMMEDIATE.
102-
*/
103-
#if (defined(CONFIG_LOG_MODE_IMMEDIATE) || defined(CONFIG_LOG_IMMEDIATE))
104-
#define ZEPHYR_LOG_MODE_IMMEDIATE 1
105-
#endif
106-
107-
#if defined(CONFIG_LOG) && !defined(ZEPHYR_LOG_MODE_IMMEDIATE) && \
108-
!defined(ZEPHYR_LOG_MODE_MINIMAL)
93+
#if defined(CONFIG_LOG) && !defined(CONFIG_LOG_MODE_IMMEDIATE) && \
94+
!defined(CONFIG_LOG_MODE_MINIMAL)
10995
#ifdef CONFIG_LOG_PROCESS_THREAD
11096
#warning "The log internal thread for log processing can't transfer the log"\
11197
"well for MCUBoot."
@@ -128,8 +114,8 @@ K_SEM_DEFINE(boot_log_sem, 1, 1);
128114
/* synchronous log mode doesn't need to be initalized by the application */
129115
#define ZEPHYR_BOOT_LOG_START() do { } while (false)
130116
#define ZEPHYR_BOOT_LOG_STOP() do { } while (false)
131-
#endif /* defined(CONFIG_LOG) && !defined(ZEPHYR_LOG_MODE_IMMEDIATE) && \
132-
* !defined(ZEPHYR_LOG_MODE_MINIMAL)
117+
#endif /* defined(CONFIG_LOG) && !defined(CONFIG_LOG_MODE_IMMEDIATE) && \
118+
* !defined(CONFIG_LOG_MODE_MINIMAL)
133119
*/
134120

135121
BOOT_LOG_MODULE_REGISTER(mcuboot);
@@ -427,8 +413,8 @@ static void do_boot(struct boot_rsp *rsp)
427413
}
428414
#endif
429415

430-
#if defined(CONFIG_LOG) && !defined(ZEPHYR_LOG_MODE_IMMEDIATE) && \
431-
!defined(CONFIG_LOG_PROCESS_THREAD) && !defined(ZEPHYR_LOG_MODE_MINIMAL)
416+
#if defined(CONFIG_LOG) && !defined(CONFIG_LOG_MODE_IMMEDIATE) && \
417+
!defined(CONFIG_LOG_PROCESS_THREAD) && !defined(CONFIG_LOG_MODE_MINIMAL)
432418
/* The log internal thread for log processing can't transfer log well as has too
433419
* low priority.
434420
* Dedicated thread for log processing below uses highest application
@@ -446,12 +432,7 @@ void boot_log_thread_func(void *dummy1, void *dummy2, void *dummy3)
446432
log_init();
447433

448434
while (1) {
449-
#if defined(CONFIG_LOG1) || defined(CONFIG_LOG2)
450-
/* support Zephyr legacy logging implementation before commit c5f2cde */
451-
if (log_process(false) == false) {
452-
#else
453435
if (log_process() == false) {
454-
#endif
455436
if (boot_log_stop) {
456437
break;
457438
}
@@ -485,8 +466,8 @@ void zephyr_boot_log_stop(void)
485466
*/
486467
(void)k_sem_take(&boot_log_sem, K_FOREVER);
487468
}
488-
#endif /* defined(CONFIG_LOG) && !defined(ZEPHYR_LOG_MODE_IMMEDIATE) && \
489-
* !defined(CONFIG_LOG_PROCESS_THREAD) && !defined(ZEPHYR_LOG_MODE_MINIMAL)
469+
#endif /* defined(CONFIG_LOG) && !defined(CONFIG_LOG_MODE_IMMEDIATE) && \
470+
* !defined(CONFIG_LOG_PROCESS_THREAD) && !defined(CONFIG_LOG_MODE_MINIMAL)
490471
*/
491472

492473
#if defined(CONFIG_BOOT_SERIAL_ENTRANCE_GPIO) || defined(CONFIG_BOOT_SERIAL_PIN_RESET) \

boot/zephyr/prj.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ CONFIG_FLASH=y
1919
# CONFIG_I2C is not set
2020

2121
CONFIG_LOG=y
22-
CONFIG_LOG_MODE_MINIMAL=y # former CONFIG_MODE_MINIMAL
22+
CONFIG_LOG_MODE_MINIMAL=y
2323
### Ensure Zephyr logging changes don't use more resources
2424
CONFIG_LOG_DEFAULT_LEVEL=0
2525
### Use info log level by default

0 commit comments

Comments
 (0)