Merge pull request #25 from abligh/improve-ssl-testing

mcuadros · mcuadros · commit 4be3718289d1 · 2015-08-12T00:16:45.000+02:00
Improve SSL testing
diff --git a/servertls_test.go b/servertls_test.go
@@ -26,7 +26,6 @@ func getServerConfig() *tls.Config {
 		ClientAuth:   tls.RequireAndVerifyClientCert,
 		Certificates: []tls.Certificate{cert},
 		ClientCAs:    capool,
-		ServerName:   "dummycert1",
 	}
 	config.Rand = rand.Reader
 
@@ -46,7 +45,7 @@ func getClientConfig() *tls.Config {
 
 	config := tls.Config{
 		Certificates:       []tls.Certificate{cert},
-		InsecureSkipVerify: true,
+		InsecureSkipVerify: false,
 		ServerName:         "dummycert1",
 		RootCAs:            capool,
 	}

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ func getServerConfig() *tls.Config {`
`26`	`26`	`ClientAuth: tls.RequireAndVerifyClientCert,`
`27`	`27`	`Certificates: []tls.Certificate{cert},`
`28`	`28`	`ClientCAs: capool,`
`29`		`- ServerName: "dummycert1",`
`30`	`29`	`}`
`31`	`30`	`config.Rand = rand.Reader`
`32`	`31`
`@@ -46,7 +45,7 @@ func getClientConfig() *tls.Config {`
`46`	`45`
`47`	`46`	`config := tls.Config{`
`48`	`47`	`Certificates: []tls.Certificate{cert},`
`49`		`- InsecureSkipVerify: true,`
	`48`	`+ InsecureSkipVerify: false,`
`50`	`49`	`ServerName: "dummycert1",`
`51`	`50`	`RootCAs: capool,`
`52`	`51`	`}`