Fixes unit tests under go 1.16, fix for UTC timestamp parsing, adds go modules support #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test fixes
The unit tests, at least under go 1.16, were failing:
I put in new certificates, separating the client from the server certificate. The server certificate now has a subject alternative name section which includes both
localhostand127.0.0.1.Timestamp parsing fixes
RFC 3339 timestamps do not have a fixed size length, but they also do not contain any spaces:
https://tools.ietf.org/html/rfc3339#section-5.8
I changed the code to terminate after the first space instead using the size of the formatting string to fix the issue.
Go modules support
Added go modules support.
If you are not happy with something or want something done better, let me know and I'll try to fix it.