Skip to content

Commit 43b138d

Browse files
author
Brock Denson
committed
[clang] unrecognized html tag causing undesirable comment lexing. fixes llvm#32680
1 parent 9cfd897 commit 43b138d

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ Bug Fixes to AST Handling
195195
- Fix incorrect name qualifiers applied to alias CTAD. (#GH136624)
196196
- Fixed ElaboratedTypes appearing within NestedNameSpecifier, which was not a
197197
legal representation. This is fixed because ElaboratedTypes don't exist anymore. (#GH43179) (#GH68670) (#GH92757)
198+
- Fix unrecognized html tag causing undesirable comment lexing (#GH152944)
198199

199200
Miscellaneous Bug Fixes
200201
^^^^^^^^^^^^^^^^^^^^^^^

clang/include/clang/AST/CommentHTMLTags.td

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ def Tr : Tag<"tr"> { let EndTagOptional = 1; }
5252
def Th : Tag<"th"> { let EndTagOptional = 1; }
5353
def Td : Tag<"td"> { let EndTagOptional = 1; }
5454
def Summary : Tag<"summary">;
55+
def Details : Tag<"details">;
56+
def Mark : Tag<"mark">;
57+
def Figure : Tag<"figure">;
58+
def FigCaption : Tag<"figcaption">;
5559

5660
// Define a list of attributes that are not safe to pass through to HTML
5761
// output if the input is untrusted.

clang/test/AST/ast-dump-comment.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,4 +139,4 @@ int Test_HTMLSummaryTag(int Aaa);
139139
// CHECK-NEXT: ParagraphComment
140140
// CHECK: HTMLStartTagComment{{.*}} Name="summary"
141141
// CHECK-NEXT: TextComment{{.*}} Text="Short summary"
142-
// CHECK-NEXT: HTMLEndTagComment{{.*}} Name="summary"
142+
// CHECK-NEXT: HTMLEndTagComment{{.*}} Name="summary"

0 commit comments

Comments
 (0)