Skip to content

Commit 7e867df

Browse files
committed
Deploy version 1.2.11
1 parent 0865835 commit 7e867df

File tree

3 files changed

+24
-6
lines changed

3 files changed

+24
-6
lines changed

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-html5video",
3-
"version": "1.2.10",
3+
"version": "1.2.11",
44
"homepage": "https://github.com/mderrick/react-html5video",
55
"authors": [
66

dist/ReactHtml5Video.js

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,19 +304,37 @@ return /******/ (function(modules) { // webpackBootstrap
304304
/**
305305
* Seeks the video timeline.
306306
* @param {number} time The value in seconds to seek to
307+
* @param {bool} forceUpdate Forces a state update without waiting for
308+
* throttled event.
307309
* @return {undefined}
308310
*/
309-
seek: function seek(time) {
311+
seek: function seek(time, forceUpdate) {
310312
this.videoEl.currentTime = time;
313+
// In some use cases, we wish not to wait for `onSeeked` or `onSeeking`
314+
// throttled event to update state so we force it. This is because
315+
// this method is often triggered when dragging a bar and can feel janky.
316+
// See https://github.com/mderrick/react-html5video/issues/43
317+
if (forceUpdate) {
318+
this.updateStateFromVideo();
319+
}
311320
},
312321

313322
/**
314323
* Sets the video volume.
315324
* @param {number} volume The volume level between 0 and 1.
325+
* @param {bool} forceUpdate Forces a state update without waiting for
326+
* throttled event.
316327
* @return {undefined}
317328
*/
318-
setVolume: function setVolume(volume) {
329+
setVolume: function setVolume(volume, forceUpdate) {
319330
this.videoEl.volume = volume;
331+
// In some use cases, we wish not to wait for `onVolumeChange`
332+
// throttled event to update state so we force it. This is because
333+
// this method is often triggered when dragging a bar and can feel janky.
334+
// See https://github.com/mderrick/react-html5video/issues/43
335+
if (forceUpdate) {
336+
this.updateStateFromVideo();
337+
}
320338
},
321339

322340
/**
@@ -1422,7 +1440,7 @@ return /******/ (function(modules) { // webpackBootstrap
14221440
* @return {undefined}
14231441
*/
14241442
seek: function seek(e) {
1425-
this.props.seek(e.target.value * this.props.duration / 100);
1443+
this.props.seek(e.target.value * this.props.duration / 100, true);
14261444
},
14271445

14281446
onFocus: function onFocus() {
@@ -1655,7 +1673,7 @@ return /******/ (function(modules) { // webpackBootstrap
16551673
* @return {undefined}
16561674
*/
16571675
changeVolume: function changeVolume(e) {
1658-
this.props.setVolume(e.target.value / 100);
1676+
this.props.setVolume(e.target.value / 100, true);
16591677
this.props.unmute();
16601678
},
16611679

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-html5video",
3-
"version": "1.2.10",
3+
"version": "1.2.11",
44
"description": "",
55
"main": "./dist/ReactHtml5Video.js",
66
"scripts": {

0 commit comments

Comments
 (0)