BLD: fix issue ILP64 OpenBLAS detection, disable BLAS for PyPy job

Disable using BLAS in the PyPy job on Azure because it was broken.
Before this PR, it uses to silently not find OpenBLAS and continue,
now we have to be explicit about it.

Author: rgommers

azure-pipelines.yml

@@ -227,6 +227,8 @@ stages:
             TEST_MODE: fast
             BITS: 64
             NPY_USE_BLAS_ILP64: '1'
+            # Broken - it builds but _multiarray_umath doesn't import - needs investigating
+            DISABLE_BLAS: '1'
 
     steps:
     - template: azure-steps-windows.yml

azure-steps-windows.yml

@@ -38,10 +38,13 @@ steps:
     # Note: ensure the `pip install .` command remains the last one here, to
     # avoid "green on failure" issues
     python -c "from tools import openblas_support; openblas_support.make_init('numpy')"
-    If ( Test-Path env:NPY_USE_BLAS_ILP64 ) {
-        python -m pip install . -Csetup-args="--vsenv" -Csetup-args="-Duse-ilp64=true" -Csetup-args="-Dblas-symbol-suffix=64_"
+    If ( Test-Path env:DISABLE_BLAS ) {
+        python -m pip install . -v -Csetup-args="--vsenv" -Csetup-args="-Dblas=none" -Csetup-args="-Dlapack=none" -Csetup-args="-Dallow-noblas=true"
+    }
+    elseif ( Test-Path env:NPY_USE_BLAS_ILP64 ) {
+        python -m pip install . -v -Csetup-args="--vsenv" -Csetup-args="-Duse-ilp64=true" -Csetup-args="-Dblas-symbol-suffix=64_"
     } else {
-        python -m pip install . -Csetup-args="--vsenv"
+        python -m pip install . -v -Csetup-args="--vsenv"
     }
   displayName: 'Build NumPy'
 

numpy/meson.build

@@ -53,6 +53,19 @@ endif
 # (see cibuildwheel settings in pyproject.toml), but used by CI jobs already
 blas_symbol_suffix = get_option('blas-symbol-suffix')
 
+use_ilp64 = get_option('use-ilp64')
+if not use_ilp64
+  # For now, keep supporting this environment variable too (same as in setup.py)
+  # `false is the default for the CLI flag, so check if env var was set
+  use_ilp64 = run_command(py,
+    [
+      '-c',
+      'import os; print(1) if os.environ.get("NPY_USE_BLAS_ILP64", "0") != "0" else print(0)'
+    ],
+    check: true
+  ).stdout().strip() == '1'
+endif
+
 
 # TODO: 64-bit (ILP64) BLAS and LAPACK support (e.g., check for more .pc files
 # so we detect `openblas64_.so` directly). Partially supported now, needs more
@@ -70,7 +83,12 @@ lapack_name = get_option('lapack')
 # pkg-config uses a lower-case name while CMake uses a capitalized name, so try
 # that too to make the fallback detection with CMake work
 if blas_name == 'openblas'
-  blas = dependency(['openblas', 'OpenBLAS'], required: false)
+  if use_ilp64
+    _openblas_names = ['openblas64', 'openblas', 'OpenBLAS']
+  else
+    _openblas_names = ['openblas', 'OpenBLAS']
+  endif
+  blas = dependency(_openblas_names, required: false)
 else
   blas = dependency(blas_name, required: false)
 endif
@@ -121,19 +139,6 @@ if have_blas
   endif
 endif
 
-use_ilp64 = get_option('use-ilp64')
-if not use_ilp64
-  # For now, keep supporting this environment variable too (same as in setup.py)
-  # `false is the default for the CLI flag, so check if env var was set
-  use_ilp64 = run_command(py,
-    [
-      '-c',
-      'import os; print(1) if os.environ.get("NPY_USE_BLAS_ILP64", "0") != "0" else print(0)'
-    ],
-    check: true
-  ).stdout().strip() == '1'
-endif
-
 # BLAS and LAPACK are dependencies for NumPy. Since NumPy 2.0, by default the
 # build will fail if they are missing; the performance impact is large, so
 # using fallback routines must be explicitly opted into by the user. xref

tools/openblas_support.py

@@ -324,7 +324,7 @@ def test_version(expected_version=None):
     data = threadpoolctl.threadpool_info()
     if len(data) != 1:
         if platform.python_implementation() == 'PyPy':
-            print(f"Check broken in CI on PyPy, data is: {data}")
+            print(f"Not using OpenBLAS for PyPy in Azure CI, so skip this")
             return
         raise ValueError(f"expected single threadpool_info result, got {data}")
     if not expected_version: