isVisibleOnScreen function aware of vertical-horizontal screen offsets

Author: JorgeCM

README.md

@@ -57,7 +57,7 @@ BubbleShowCaseBuilder(this) //Activity instance
                         //Called when the user clicks on the background dim
                     }
                 })
-                .targetView(buttonArrowRightShowCase) //View to point out
+                .targetView(view) //View to point out
                 .show() //Display the ShowCase
 ```
 

app/src/main/java/com/elconfidencial/bubbleshowcase/MainActivity.kt

@@ -17,16 +17,6 @@ class MainActivity : AppCompatActivity() {
         setUpListeners()
     }
 
-    override fun onCreateOptionsMenu(menu: Menu): Boolean {
-        menuInflater.inflate(R.menu.menu_test, menu)
-        return true
-    }
-
-    override fun onOptionsItemSelected(item: MenuItem): Boolean {
-        val id = item.itemId
-        return if(id == R.id.action_test) true else super.onOptionsItemSelected(item)
-    }
-
     private fun setUpListeners(){
         buttonSimpleShowCase.setOnClickListener { getSimpleShowCaseBuilder().show() }
         buttonColorShowCase.setOnClickListener { getCustomColorShowCaseBuilder().show() }

bubbleshowcase/src/main/java/com/elconfidencial/bubbleshowcase/BubbleShowCase.kt

@@ -104,7 +104,7 @@ class BubbleShowCase(builder: BubbleShowCaseBuilder){
                     bubbleMessageViewBuilder = getBubbleMessageViewBuilder()
                 }
 
-                if (ScreenUtils.isVisibleOnScreen(target)) {
+                if (isVisibleOnScreen(target)) {
                     addTargetViewAtBackgroundDimLayout(target, backgroundDimLayout)
                     addBubbleMessageViewDependingOnTargetView(target, bubbleMessageViewBuilder!!, backgroundDimLayout)
                 } else {
@@ -375,6 +375,15 @@ class BubbleShowCase(builder: BubbleShowCaseBuilder){
         return bitmap
     }
 
+    private fun isVisibleOnScreen(targetView: View?): Boolean {
+        if(targetView!=null){
+            if(getXposition(targetView) >= 0 && getYposition(targetView) >= 0){
+                return getXposition(targetView) != 0 || getYposition(targetView) != 0
+            }
+        }
+        return false
+    }
+
     private fun getXposition(targetView: View): Int{
         return ScreenUtils.getAxisXpositionOfViewOnScreen(targetView) - getScreenHorizontalOffset()
     }

bubbleshowcase/src/main/java/com/elconfidencial/bubbleshowcase/ScreenUtils.kt

@@ -61,15 +61,6 @@ object ScreenUtils {
         return androidContent.parent.parent as ViewGroup
     }
 
-    fun isVisibleOnScreen(targetView: View?): Boolean {
-        if(targetView!=null){
-            if(getAxisXpositionOfViewOnScreen(targetView) >= 0 && getAxisYpositionOfViewOnScreen(targetView) >= 0){
-                return getAxisXpositionOfViewOnScreen(targetView) != 0 || getAxisYpositionOfViewOnScreen(targetView) != 0
-            }
-        }
-        return false
-    }
-
     fun getStatusBarHeight(context: Context): Int {
         var result = 0
         val resourceId = context.resources.getIdentifier("status_bar_height", "dimen", "android")