Skip to content

Commit ed8d3f4

Browse files
authored
Do a full clone so that we have enough information to determine the release (#29)
This PR ensures that in the release workflow we do a full clone, so that setuptools_scm has enough information to compute a version number. We don't strictly need this if we only ever expect to be making releases from a tagged commit (which seems likely), but the failure mode if this is left out is that we compute a wrong version. So it seems better to include it. If some future version of setuptools_scm makes this an error, it should be safe to remove this. See pypa/setuptools-scm#480 for more discussion.
1 parent 5751a56 commit ed8d3f4

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

.github/workflows/on-release.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ jobs:
1111

1212
steps:
1313
- uses: actions/checkout@v3
14+
with:
15+
fetch-depth: 0
1416
- name: Set up Python 3.10
1517
uses: actions/setup-python@v4
1618
with:

0 commit comments

Comments
 (0)