Fixed errors.

Author: Raza403

classes/certificate.php

@@ -34,7 +34,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class certificate {
-
     /**
      * Send the file inline to the browser.
      */
@@ -293,7 +292,7 @@ public static function download_all_issues_for_instance(\mod_customcert\template
     public static function download_all_for_site(): void {
         global $DB;
 
-        list($namefields, $nameparams) = \core_user\fields::get_sql_fullname();
+        [$namefields, $nameparams] = \core_user\fields::get_sql_fullname();
         $sql = "SELECT ci.*, $namefields as fullname, ct.id as templateid, ct.name as templatename, ct.contextid
                   FROM {customcert_issues} ci
                   JOIN {user} u
@@ -350,7 +349,7 @@ public static function get_issues($customcertid, $groupmode, $cm, $limitfrom, $l
         global $DB;
 
         // Get the conditional SQL.
-        list($conditionssql, $conditionsparams) = self::get_conditional_issues_sql($cm, $groupmode);
+        [$conditionssql, $conditionsparams] = self::get_conditional_issues_sql($cm, $groupmode);
 
         // If it is empty then return an empty array.
         if (empty($conditionsparams)) {
@@ -389,7 +388,7 @@ public static function get_number_of_issues($customcertid, $cm, $groupmode) {
         global $DB;
 
         // Get the conditional SQL.
-        list($conditionssql, $conditionsparams) = self::get_conditional_issues_sql($cm, $groupmode);
+        [$conditionssql, $conditionsparams] = self::get_conditional_issues_sql($cm, $groupmode);
 
         // If it is empty then return 0.
         if (empty($conditionsparams)) {
@@ -428,7 +427,7 @@ public static function get_conditional_issues_sql($cm, $groupmode) {
         // Get all users that can manage this certificate to exclude them from the report.
         $certmanagers = array_keys(get_users_by_capability($context, 'mod/customcert:manage', 'u.id'));
         $certmanagers = array_merge($certmanagers, array_keys(get_admins()));
-        list($sql, $params) = $DB->get_in_or_equal($certmanagers, SQL_PARAMS_NAMED, 'cert');
+        [$sql, $params] = $DB->get_in_or_equal($certmanagers, SQL_PARAMS_NAMED, 'cert');
         $conditionssql .= "AND NOT u.id $sql \n";
         $conditionsparams += $params;
 
@@ -464,7 +463,7 @@ public static function get_conditional_issues_sql($cm, $groupmode) {
                     return ['', []];
                 }
 
-                list($sql, $params) = $DB->get_in_or_equal($groupusers, SQL_PARAMS_NAMED, 'grp');
+                [$sql, $params] = $DB->get_in_or_equal($groupusers, SQL_PARAMS_NAMED, 'grp');
                 $conditionssql .= "AND u.id $sql ";
                 $conditionsparams += $params;
             }
@@ -605,22 +604,21 @@ private static function generate_code_digits_with_hyphens(): string {
 
         // Define the character set (digits only).
         $characters = '0123456789';
-        $charCount = strlen($characters); // Cache the length to optimize loop performance.
+        $charcount = strlen($characters); // Cache the length to optimize loop performance.
         $length = 12; // Total length excluding hyphens.
 
         do {
             // Generate a raw code.
             $rawcode = '';
             for ($i = 0; $i < $length; $i++) {
-                $rawcode .= $characters[random_int(0, $charCount - 1)]; // Secure random number selection.
+                $rawcode .= $characters[random_int(0, $charcount - 1)]; // Secure random number selection.
             }
 
             // Format the code as XXXX-XXXX-XXXX.
             $code = substr($rawcode, 0, 4) . '-' . substr($rawcode, 4, 4) . '-' . substr($rawcode, 8, 4);
 
             // Check if the generated code already exists in the database.
             $exists = $DB->record_exists('customcert_issues', ['code' => $code]);
-
         } while ($exists); // Repeat until a unique code is found.
 
         return $code;

lib.php

@@ -350,18 +350,26 @@ function customcert_extend_settings_navigation(settings_navigation $settings, na
     if (has_capability('mod/customcert:manage', $settings->get_page()->cm->context)) {
         // Get the template id.
         $templateid = $DB->get_field('customcert', 'templateid', ['id' => $settings->get_page()->cm->instance]);
-        $node = navigation_node::create(get_string('editcustomcert', 'customcert'),
-                new moodle_url('/mod/customcert/edit.php', ['tid' => $templateid]),
-                navigation_node::TYPE_SETTING, null, 'mod_customcert_edit',
-                new pix_icon('t/edit', ''));
+        $node = navigation_node::create(
+            get_string('editcustomcert', 'customcert'),
+            new moodle_url('/mod/customcert/edit.php', ['tid' => $templateid]),
+            navigation_node::TYPE_SETTING,
+            null,
+            'mod_customcert_edit',
+            new pix_icon('t/edit', '')
+        );
         $customcertnode->add_node($node, $beforekey);
     }
 
     if (has_capability('mod/customcert:verifycertificate', $settings->get_page()->cm->context)) {
-        $node = navigation_node::create(get_string('verifycertificate', 'customcert'),
+        $node = navigation_node::create(
+            get_string('verifycertificate', 'customcert'),
             new moodle_url('/mod/customcert/verify_certificate.php', ['contextid' => $settings->get_page()->cm->context->id]),
-            navigation_node::TYPE_SETTING, null, 'mod_customcert_verify_certificate',
-            new pix_icon('t/check', ''));
+            navigation_node::TYPE_SETTING,
+            null,
+            'mod_customcert_verify_certificate',
+            new pix_icon('t/check', '')
+        );
         $customcertnode->add_node($node, $beforekey);
     }
 
@@ -380,8 +388,10 @@ function customcert_extend_settings_navigation(settings_navigation $settings, na
 function mod_customcert_myprofile_navigation(core_user\output\myprofile\tree $tree, $user, $iscurrentuser, $course) {
     global $USER;
 
-    if (($user->id != $USER->id)
-            && !has_capability('mod/customcert:viewallcertificates', context_system::instance())) {
+    if (
+        ($user->id != $USER->id)
+            && !has_capability('mod/customcert:viewallcertificates', context_system::instance())
+    ) {
         return;
     }
 
@@ -392,8 +402,13 @@ function mod_customcert_myprofile_navigation(core_user\output\myprofile\tree $tr
         $params['course'] = $course->id;
     }
     $url = new moodle_url('/mod/customcert/my_certificates.php', $params);
-    $node = new core_user\output\myprofile\node('miscellaneous', 'mycustomcerts',
-        get_string('mycertificates', 'customcert'), null, $url);
+    $node = new core_user\output\myprofile\node(
+        'miscellaneous',
+        'mycustomcerts',
+        get_string('mycertificates', 'customcert'),
+        null,
+        $url
+    );
     $tree->add_node($node);
 }
 
@@ -431,8 +446,14 @@ function mod_customcert_inplace_editable($itemtype, $itemid, $newvalue) {
         $updateelement->name = clean_param($newvalue, PARAM_TEXT);
         $DB->update_record('customcert_elements', $updateelement);
 
-        return new \core\output\inplace_editable('mod_customcert', 'elementname', $element->id, true,
-            $updateelement->name, $updateelement->name);
+        return new \core\output\inplace_editable(
+            'mod_customcert',
+            'elementname',
+            $element->id,
+            true,
+            $updateelement->name,
+            $updateelement->name
+        );
     }
 }
 
@@ -449,14 +470,14 @@ function mod_customcert_inplace_editable($itemtype, $itemid, $newvalue) {
  * @param string $cert_code The unique code of the certificate.
  * @return string The generated public URL for the certificate.
  */
-function generate_public_url_for_certificate(string $cert_code): string {
+function generate_public_url_for_certificate(string $certcode): string {
     global $CFG;
 
     // Generate a security token for the certificate using a private function.
-    $token = calculate_signature($cert_code);
+    $token = calculate_signature($certcode);
 
     // Construct and return the public URL to view the certificate.
-    return $CFG->wwwroot . '/mod/customcert/view_user_cert.php?cert_code=' . urlencode($cert_code) . '&token=' . urlencode($token);
+    return $CFG->wwwroot . '/mod/customcert/view_user_cert.php?cert_code=' . urlencode($certcode) . '&token=' . urlencode($token);
 }
 
 /**
@@ -467,22 +488,22 @@ function generate_public_url_for_certificate(string $cert_code): string {
  * It prevents unauthorized access by ensuring that only valid certificates can
  * be accessed through a generated URL.
  *
- * The signature is generated using the HMAC (Hash-based Message Authentication Code) 
+ * The signature is generated using the HMAC (Hash-based Message Authentication Code)
  * method with SHA-256, ensuring strong security. It uses Moodle's `siteidentifier`
  * as the secret key, making it unique to each Moodle installation.
  *
  * @param string $cert_code The unique certificate code.
  * @return string The generated HMAC signature.
  */
-function calculate_signature(string $cert_code): string {
+function calculate_signature(string $certcode): string {
     global $CFG;
 
     // Define a namespaced message prefix to avoid signature collisions.
-    $messagePrefix = 'mod_customcert:view_user_cert';
+    $messageprefix = 'mod_customcert:view_user_cert';
 
     // Construct the message that will be signed.
     // This includes the prefix and the certificate code to create a unique hash.
-    $message = $messagePrefix . '|' . $cert_code;
+    $message = $messageprefix . '|' . $certcode;
 
     // Use Moodle's unique site identifier as the secret key for HMAC.
     // This ensures that signatures are installation-specific.

view_user_cert.php

@@ -1,5 +1,20 @@
 <?php
+// This file is part of Moodle - https://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <https://www.gnu.org/licenses/>.
 // Include required Moodle configuration and custom certificate library.
+
 require_once(__DIR__ . '/../../config.php');
 require_once($CFG->dirroot . '/mod/customcert/lib.php');
 
@@ -18,6 +33,7 @@
  * properly and showing the error message in an alert box.
  *
  * @param string $message The error message to display.
+ * @package mod_customcert
  */
 function display_error_page($message) {
     global $OUTPUT;
@@ -30,23 +46,23 @@ function display_error_page($message) {
 
 // Retrieve certificate code and verification token from URL parameters.
 // 'optional_param' is used instead of 'required_param' to avoid Moodle throwing an automatic error page.
-$cert_code = optional_param('cert_code', '', PARAM_ALPHANUMEXT);
+$certcode = optional_param('cert_code', '', PARAM_ALPHANUMEXT);
 $token = optional_param('token', '', PARAM_ALPHANUMEXT);
 
 // Ensure both required parameters are provided.
-if (empty($cert_code) || empty($token)) {
+if (empty($certcode) || empty($token)) {
     display_error_page('Certificate code or verification token is missing. Please check the URL and try again.');
 }
 
 // Validate the provided token by regenerating it using the expected algorithm.
-$expected_token = calculate_signature($cert_code);
-if ($token !== $expected_token) {
+$expectedtoken = calculate_signature($certcode);
+if ($token !== $expectedtoken) {
     display_error_page('The verification token is invalid for this certificate. Please check the URL and try again.');
 }
 
 // Retrieve the certificate issue entry using the provided certificate code.
 // This helps fetch the associated user ID to verify ownership.
-$issue = $DB->get_record('customcert_issues', ['code' => $cert_code], '*');
+$issue = $DB->get_record('customcert_issues', ['code' => $certcode], '*');
 
 if (!$issue) {
     display_error_page('The certificate with the provided code could not be found. Please verify the certificate code and try again.');