Add scope and types to variables (#499)

Author: mdjnelson

classes/output/verify_certificate_result.php

@@ -39,32 +39,32 @@ class verify_certificate_result implements templatable, renderable {
     /**
      * @var string The URL to the user's profile.
      */
-    public $userprofileurl;
+    public string $userprofileurl;
 
     /**
      * @var string The user's fullname.
      */
-    public $userfullname;
+    public string $userfullname;
 
     /**
      * @var string The URL to the course page.
      */
-    public $courseurl;
+    public string $courseurl;
 
     /**
      * @var string The course's fullname.
      */
-    public $coursefullname;
+    public string $coursefullname;
 
     /**
      * @var string The certificate's name.
      */
-    public $certificatename;
+    public string $certificatename;
 
     /**
-     * @var int The certificate's expiry date (optional).
+     * @var int|null The certificate's expiry date (optional).
      */
-    public $expiry;
+    public ?int $expiry;
 
     /**
      * Constructor.

element/expiry/classes/element.php

@@ -38,30 +38,30 @@ class element extends \mod_customcert\element {
     /**
      * Date - Relative expiry date of 1 year
      */
-    const EXPIRY_ONE = '-8';
+    private const EXPIRY_ONE = '-8';
 
     /**
      * Date - Relative expiry date of 2 year
      */
-    const EXPIRY_TWO = '-9';
+    private const EXPIRY_TWO = '-9';
 
     /**
      * Date - Relative expiry date of 3 year
      */
-    const EXPIRY_THREE = '-10';
+    private const EXPIRY_THREE = '-10';
 
     /**
      * Date - Relative expiry date of 4 year
      */
-    const EXPIRY_FOUR = '-11';
+    private const EXPIRY_FOUR = '-11';
 
     /**
      * Date - Relative expiry date of 5 year
      */
-    const EXPIRY_FIVE = '-12';
+    private const EXPIRY_FIVE = '-12';
 
     /** @var array Map EXPIRY_ consts to strtotime()'s $datetime param. */
-    private $relative = [
+    private array $relative = [
         self::EXPIRY_ONE => '+1 year',
         self::EXPIRY_TWO => '+2 years',
         self::EXPIRY_THREE => '+3 years',