Fix issuing certificate when there are no issues yet (#659)

anieminen · mdjnelson · commit 869d7bc24f40 · 2025-02-22T18:49:48.000Z
diff --git a/classes/task/issue_certificates_task.php b/classes/task/issue_certificates_task.php
@@ -83,7 +83,7 @@ public function execute() {
         // Add condition based on certificate execution period.
         if ($certificateexecutionperiod > 0) {
             // Include courses with no end date or end date greater than the specified period.
-            $sql .= " AND (co.enddate > :enddate OR (co.enddate = 0 AND ci.timecreated > :enddate2))";
+            $sql .= " AND (co.enddate > :enddate OR (co.enddate = 0 AND (ci.timecreated > :enddate2 OR ci.timecreated IS NULL)))";
             $params['enddate'] = time() - $certificateexecutionperiod;
             $params['enddate2'] = $params['enddate'];
         }

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public function execute() {`
`83`	`83`	`// Add condition based on certificate execution period.`
`84`	`84`	`if ($certificateexecutionperiod > 0) {`
`85`	`85`	`// Include courses with no end date or end date greater than the specified period.`
`86`		`- $sql .= " AND (co.enddate > :enddate OR (co.enddate = 0 AND ci.timecreated > :enddate2))";`
	`86`	`+ $sql .= " AND (co.enddate > :enddate OR (co.enddate = 0 AND (ci.timecreated > :enddate2 OR ci.timecreated IS NULL)))";`
`87`	`87`	`$params['enddate'] = time() - $certificateexecutionperiod;`
`88`	`88`	`$params['enddate2'] = $params['enddate'];`
`89`	`89`	`}`