Make index for code column not unique (#674)

Author: mdjnelson

db/install.xml

@@ -57,7 +57,7 @@
       </KEYS>
       <INDEXES>
         <INDEX NAME="userid-customcertid" UNIQUE="false" FIELDS="userid, customcertid"/>
-        <INDEX NAME="code" UNIQUE="true" FIELDS="code"/>
+        <INDEX NAME="code" UNIQUE="false" FIELDS="code"/>
       </INDEXES>
     </TABLE>
     <TABLE NAME="customcert_pages" COMMENT="Stores each page of a custom cert">

db/upgrade.php

@@ -298,18 +298,22 @@ function xmldb_customcert_upgrade($oldversion) {
         upgrade_mod_savepoint(true, 2024042205, 'customcert');
     }
 
-    // Define the new unique index for the 'code' column.
-    if ($oldversion < 2024042209) {
+    if ($oldversion < 2024042210) {
         $table = new xmldb_table('customcert_issues');
         $index = new xmldb_index('code', XMLDB_INDEX_UNIQUE, ['code']);
 
-        // Check if an index exists before adding.
+        if ($dbman->index_exists($table, $index)) {
+            $dbman->drop_index($table, $index);
+        }
+
+        $index = new xmldb_index('code', XMLDB_INDEX_NOTUNIQUE, ['code']);
+
         if (!$dbman->index_exists($table, $index)) {
             $dbman->add_index($table, $index);
         }
 
         // Update the plugin version in the database.
-        upgrade_plugin_savepoint(true, 2024042209, 'mod', 'customcert');
+        upgrade_plugin_savepoint(true, 2024042210, 'mod', 'customcert');
     }
 
     return true;

version.php

@@ -24,7 +24,7 @@
 
 defined('MOODLE_INTERNAL') || die('Direct access to this script is forbidden.');
 
-$plugin->version   = 2024042209; // The current module version (Date: YYYYMMDDXX).
+$plugin->version   = 2024042210; // The current module version (Date: YYYYMMDDXX).
 $plugin->requires  = 2024042200; // Requires this Moodle version (4.4).
 $plugin->cron      = 0; // Period for cron to check this module (secs).
 $plugin->component = 'mod_customcert';