Moved suffix lang strings to customcert lang file (#499)

AMOS BEGIN
  MOV [numbersuffix_st_as_in_first,customcertelement_date],[numbersuffix_st_as_in_first,customcert]
  MOV [numbersuffix_nd_as_in_second,customcertelement_date],[numbersuffix_nd_as_in_second,customcert]
  MOV [numbersuffix_rd_as_in_third,customcertelement_date],[numbersuffix_rd_as_in_third,customcert]
AMOS END

Author: mdjnelson

classes/element_helper.php

@@ -785,11 +785,11 @@ private static function get_ordinal_number_suffix(int $day): string {
             switch ($day % 10) {
                 // Handle 1st, 2nd, 3rd.
                 case 1:
-                    return get_string('numbersuffix_st_as_in_first', 'customcertelement_date');
+                    return get_string('numbersuffix_st_as_in_first', 'customcert');
                 case 2:
-                    return get_string('numbersuffix_nd_as_in_second', 'customcertelement_date');
+                    return get_string('numbersuffix_nd_as_in_second', 'customcert');
                 case 3:
-                    return get_string('numbersuffix_rd_as_in_third', 'customcertelement_date');
+                    return get_string('numbersuffix_rd_as_in_third', 'customcert');
             }
         }
         return 'th';

element/date/lang/en/customcertelement_date.php

@@ -34,9 +34,6 @@
 $string['enrolmentenddate'] = 'Enrolment end date';
 $string['enrolmentstartdate'] = 'Enrolment start date';
 $string['issueddate'] = 'Issued date';
-$string['numbersuffix_nd_as_in_second'] = 'nd';
-$string['numbersuffix_rd_as_in_third'] = 'rd';
-$string['numbersuffix_st_as_in_first'] = 'st';
 $string['pluginname'] = 'Date';
 $string['privacy:metadata'] = 'The Date plugin does not store any personal data.';
 $string['userdateformat'] = 'User date format';

element/expiry/lang/en/customcertelement_expiry.php

@@ -41,9 +41,6 @@
 $string['expirydatethree'] = 'Expiry date (3 years)';
 $string['expirydatetwo'] = 'Expiry date (2 years)';
 $string['issueddate'] = 'Issued date';
-$string['numbersuffix_nd_as_in_second'] = 'nd';
-$string['numbersuffix_rd_as_in_third'] = 'rd';
-$string['numbersuffix_st_as_in_first'] = 'st';
 $string['pluginname'] = 'Expiry';
 $string['privacy:metadata'] = 'The Expiry plugin does not store any personal data.';
 $string['startfrom'] = 'Start date';

lang/en/customcert.php

@@ -163,6 +163,9 @@
 $string['notemplates'] = 'No templates';
 $string['notissued'] = 'Not awarded';
 $string['notverified'] = 'Not verified';
+$string['numbersuffix_nd_as_in_second'] = 'nd';
+$string['numbersuffix_rd_as_in_third'] = 'rd';
+$string['numbersuffix_st_as_in_first'] = 'st';
 $string['options'] = 'Options';
 $string['page'] = 'Page {$a}';
 $string['pluginadministration'] = 'Custom certificate administration';