Reordered lang strings and removed duplicates (#531)

Author: mdjnelson

classes/task/issue_certificates_task.php

@@ -39,8 +39,8 @@ class issue_certificates_task extends \core\task\scheduled_task {
      *
      * @return string
      */
-    public function get_name() {
-        return get_string('issuecertificate', 'customcert');
+    public function get_name(): string {
+        return get_string('taskissuecertificate', 'customcert');
     }
 
     /**

lang/en/customcert.php

@@ -34,7 +34,7 @@
 $string['cannotverifyallcertificates'] = 'You do not have the permission to verify all certificates on the site.';
 $string['certificate'] = 'Certificate';
 $string['certificateexecutionperiod'] = 'Certificate execution period';
-$string['certificateexecutionperiod_desc'] = 'Specify the period for which certificates should be executed based after the course end date. Set to 0 to execute all certificates, regardless of their age.';
+$string['certificateexecutionperiod_desc'] = 'If not 0, the task will not process certificates whose course has been inactive or the last issue is older than the configured time. This may help to improve the performance of the scheduled task.';
 $string['certificatesperrun'] = 'Certificates per run';
 $string['certificatesperrun_desc'] = 'Enter the number of certificates to process per scheduled task run where 0 means it will process all certificates.';
 $string['code'] = 'Code';
@@ -128,7 +128,7 @@
 $string['height'] = 'Height';
 $string['height_help'] = 'This is the height of the certificate PDF in mm. For reference an A4 piece of paper is 297mm high and a letter is 279mm high.';
 $string['includeinnotvisiblecourses'] = 'Include certificates in hidden courses';
-$string['includeinnotvisiblecourses_desc'] = 'Check this box to include certificates in courses that are not visible to the user.';
+$string['includeinnotvisiblecourses_desc'] = 'Certificates from hidden courses are not proccesed by default. If you want to include them, enable this setting.';
 $string['invalidcode'] = 'Invalid code supplied.';
 $string['invalidcolour'] = 'Invalid colour chosen, please enter a valid HTML colour name, or a six-digit, or three-digit hexadecimal colour.';
 $string['invalidelementwidthorheightnotnumber'] = 'Please enter a valid number.';
@@ -215,6 +215,7 @@
 $string['subplugintype_customcertelement'] = 'Element';
 $string['subplugintype_customcertelement_plural'] = 'Elements';
 $string['taskemailcertificate'] = 'Handles emailing certificates.';
+$string['taskissuecertificate'] = 'Issue certificates task';
 $string['templatename'] = 'Template name';
 $string['templatenameexists'] = 'That template name is currently in use, please choose another.';
 $string['topcenter'] = 'Center';
@@ -224,6 +225,8 @@
 $string['uploadimage'] = 'Upload image';
 $string['uploadimagedesc'] = 'This link will take you to a new screen where you will be able to upload images. Images uploaded using
 this method will be available throughout your site to all users who are able to create a certificate.';
+$string['useadhoc'] = 'Use Email Certificate adhoc task';
+$string['useadhoc_desc'] = 'If enabled, the email will be processed on an adhoc task created per issue. If disabled, the email will be processed by the scheduled task. This may help to improve the performance of the scheduled task.';
 $string['userlanguage'] = 'Use user preferences';
 $string['userlanguage_help'] = 'You can force the language of the certificate to override the user\'s language preferences.';
 $string['verified'] = 'Verified';
@@ -238,21 +241,3 @@
 $string['verifycertificatedesc'] = 'This link will take you to a new screen where you will be able to verify certificates on the site';
 $string['width'] = 'Width';
 $string['width_help'] = 'This is the width of the certificate PDF in mm. For reference an A4 piece of paper is 210mm wide and a letter is 216mm wide.';
-
-$string['userlanguage'] = 'Use user preferences';
-$string['languageoptions'] = 'Force Certificate Language';
-$string['userlanguage_help'] = 'You can force the language of the certificate to override the user\'s language preferences.';
-
-// Scheduled task configuration performance settings.
-$string['certificateexecutionperiod'] = 'Ignore inactive certificates older than';
-$string['certificateexecutionperiod_desc'] = 'If not 0, the task will not process certificates whose course has been inactive or the last issue is older than the configured time. This may help to improve the performance of the scheduled task.';
-$string['certificatesperrun'] = 'Certificates per run';
-$string['certificatesperrun_desc'] = 'Enter the number of certificates to process per scheduled task run where 0 means it will process all certificates.';
-$string['customcert:managelanguages'] = 'Manage language on edit form';
-$string['includeinnotvisiblecourses'] = 'Include certificates in hidden courses';
-$string['includeinnotvisiblecourses_desc'] = 'Certificates from hidden courses are not proccesed by default. If you want to include them, enable this setting.';
-$string['scheduledtaskconfigheading'] = 'Scheduled task configuration';
-$string['scheduledtaskconfigdesc'] = 'Configure the settings for the scheduled task that processes certificates.';
-$string['issuecertificate'] = 'Issue certificates task';
-$string['useadhoc'] = 'Use Email Certificate adhoc task';
-$string['useadhoc_desc'] = 'If enabled, the email will be processed on an adhoc task created per issue. If disabled, the email will be processed by the scheduled task. This may help to improve the performance of the scheduled task.';