Add unit tests for issue_created, issue_deleted

[fulldecent]

Extending #675

We now have events for certificate issue, actions, and now we just need to add testing for them.

Work plan

• Rebase all branches in https://github.com/modern-training-solutions/moodle-mod_customcert on top of updated latest code in mdjnelson origin.
• Check that we are not using the old event name (certificate_issued) in our production environment. (Good, we are not.)
• Implement unit tests in new work branch in https://github.com/modern-training-solutions/moodle-mod_customcert
• @fulldecent to make PR here.

[fulldecent]

Hi @Raza403 I am ready for this one so we can start loading certificates into CMS when students get their eCard.

Can you please discuss any questions so we can get this to READY status on our board?

[mdjnelson]

Please see https://github.com/mdjnelson/moodle-mod_customcert/blob/MOODLE_500_STABLE/tests/event/events_test.php for how to write unit tests for events.

[Raza403]

Rebase all branches in https://github.com/modern-training-solutions/moodle-mod_customcert on top of updated latest code in mdjnelson origin.

Rebased.

[mdjnelson]

Sorry, is this related to creating unit tests? I don't see anything on that branch about unit tests. Also, please create a PR rather than linking to the branch as you have done before. :)

[mdjnelson]

Can you please create unit tests for this please @Raza403?

[Raza403]

@mdjnelson I am working on it, will make a PR next week.

[mdjnelson]

Thanks, it's much appreciated.

[fulldecent]

Hi @mdjnelson the first step here is that our own fork of this project needs to rebase all work ontop of your latest version here.

This is an internal step for my team. No action or review is required from you on this step. It is strictly FYI as we are building in public.

We have not started adding unit tests. But when we do, it will be a branch living at https://github.com/modern-training-solutions/moodle-mod_customcert. And yes, when we have some progress I will indeed create a PR here.

[mdjnelson]

Thanks @fulldecent.