test: create/delete unit test #706
Conversation
… being generated. This PR is made for #1 and #2 custom cert, updated the names of both code generation methods. Added view_user_cert page, a logged in user can see certificate if having a valid token and ecard code. This is being used from view_tokens.php page. customcert view certificate function is made. This is made for mdjnelson#212 Updated verify certificate URL. This PR is made for 221 Updated the verify URL for QR code.
… being generated. This PR is made for #1 and #2 custom cert, updated the names of both code generation methods. Added view_user_cert page, a logged in user can see certificate if having a valid token and ecard code. This is being used from view_tokens.php page. customcert view certificate function is made. This is made for mdjnelson#212 Updated verify certificate URL. This PR is made for 221 Updated the verify URL for QR code.
fulldecent
changed the title
|
Hi @Raza403 I see some unrelated changes here (we are targeting the MOODLE 404 branch. Can you please squash/rebase on top of MOODLE_404_STABLE? While you are doing this, please carefully review the diff before you make this the commit. For example, this commit makes changes to the database, that should not be in-scope for a change that affects on test cases. |
Raza403
force-pushed
the
features/create-delete-unit-test
branch
from
ccbe44b to
c025ac5
Compare
Raza403
force-pushed
the
features/create-delete-unit-test
branch
from
c025ac5 to
178d8fe
Compare
|
You're right — after investigating, I found that the extra commits are coming from our fork’s MOODLE_404_STABLE branch. It appears that we previously submitted PRs for those changes, and @mdjnelson may have manually applied them directly to the upstream without merging our original PRs. As a result, our fork’s MOODLE_404_STABLE now includes those commits, even though they were already incorporated upstream. That history is now showing up in every new PR, even when unrelated. I’ve tried everything I could to isolate the current changes — including resetting to the real upstream, cherry-picking the single intended commit, and force-pushing a clean branch. Despite that, GitHub continues to show unrelated commits in the PR diff, likely due to how the forked base branch has diverged. You can see in the screenshot that my local branch only contains one clean commit, but the PR still picks up historical noise from the base. 
|
|
To make it easier just create a branch for this PR, base it on my branch and then cherry-pick the commit that has been added to add unit tests. :) |
|
Created a clean PR here, it is safe to close this PR. |
|
You can always force push with git instead of creating another PR. :) |
No description provided.