refactor(lint): extract createAjv() to utils

Author: caugner

lint/linter/test-schema.ts

@@ -1,27 +1,15 @@
 /* This file is a part of @mdn/browser-compat-data
  * See LICENSE file for more information. */
 
-import { Ajv } from 'ajv';
-import ajvErrors from 'ajv-errors';
-import ajvFormats from 'ajv-formats';
 import betterAjvErrors from 'better-ajv-errors';
 
+import { createAjv } from '../../utils/index.js';
 import { Linter, Logger, LinterData } from '../utils.js';
 
 import compatDataSchema from './../../schemas/compat-data.schema.json' with { type: 'json' };
 import browserDataSchema from './../../schemas/browsers.schema.json' with { type: 'json' };
 
-const ajv = new Ajv({ allErrors: true });
-// We use 'fast' because as a side effect that makes the "uri" format more lax.
-// By default the "uri" format rejects ① and similar in URLs.
-ajvFormats.default(ajv, { mode: 'fast' });
-// Allow for custom error messages to provide better directions for contributors
-ajvErrors.default(ajv);
-
-// Define keywords for schema->TS converter
-ajv.addKeyword('tsEnumNames');
-ajv.addKeyword('tsName');
-ajv.addKeyword('tsType');
+const ajv = createAjv();
 
 export default {
   name: 'JSON Schema',

utils/ajv.ts

@@ -0,0 +1,23 @@
+import { Ajv } from 'ajv';
+import ajvErrors from 'ajv-errors';
+import ajvFormats from 'ajv-formats';
+
+/**
+ * Returns a new pre-configured Ajv instance.
+ * @returns the Ajv instance.
+ */
+export const createAjv = (): Ajv => {
+  const ajv = new Ajv({ allErrors: true });
+  // We use 'fast' because as a side effect that makes the "uri" format more lax.
+  // By default the "uri" format rejects ① and similar in URLs.
+  ajvFormats.default(ajv, { mode: 'fast' });
+  // Allow for custom error messages to provide better directions for contributors
+  ajvErrors.default(ajv);
+
+  // Define keywords for schema->TS converter
+  ajv.addKeyword('tsEnumNames');
+  ajv.addKeyword('tsName');
+  ajv.addKeyword('tsType');
+
+  return ajv;
+};

utils/index.ts

@@ -1,11 +1,20 @@
 /* This file is a part of @mdn/browser-compat-data
  * See LICENSE file for more information. */
 
+import { createAjv } from './ajv.js';
 import iterSupport from './iter-support.js';
 import query from './query.js';
 import spawn from './spawn.js';
 import spawnAsync from './spawn-async.js';
 import walk from './walk.js';
 import normalizePath from './normalize-path.js';
 
-export { iterSupport, normalizePath, query, spawn, spawnAsync, walk };
+export {
+  createAjv,
+  iterSupport,
+  normalizePath,
+  query,
+  spawn,
+  spawnAsync,
+  walk,
+};