Skip to content

Commit 1a1aa95

Browse files
committed
fix(scripts/update-browser-releases): improve Safari beta detection
1 parent d8ea2f3 commit 1a1aa95

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

scripts/update-browser-releases/safari.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ interface Release {
2626
const extractReleaseData = (str): Release | null => {
2727
// Note: \s is needed as some spaces in Apple source are non-breaking
2828
const result =
29-
/Released\s+(.*)\s*\s*(?:Version\s+)?(\d+(?:\.\d+)*)\s*(\s*beta)?\s*\((.*)\)/.exec(
29+
/Released\s+(.*)\s*\s*(?:Version\s+)?(\d+(?:\.\d+)*)\s*(?:\s*beta)?\s*\((.*)\)/.exec(
3030
str,
3131
);
3232
if (!result) {
@@ -35,11 +35,12 @@ const extractReleaseData = (str): Release | null => {
3535
);
3636
return null;
3737
}
38+
const isBeta = /\bbeta\b/i.test(str);
3839
return {
3940
date: new Date(`${result[1]} UTC`).toISOString().substring(0, 10),
4041
version: result[2].replace(/\.0$/, ''),
41-
channel: result[3] ? 'beta' : 'retired',
42-
engineVersion: result[4].substring(2),
42+
channel: isBeta ? 'beta' : 'retired',
43+
engineVersion: result[3].substring(2),
4344
releaseNote: '',
4445
};
4546
};
@@ -79,7 +80,10 @@ export const updateSafariReleases = async (options) => {
7980
if (releases[id].kind !== 'article') {
8081
continue;
8182
}
82-
const releaseDataEntry = extractReleaseData(releases[id].abstract[0].text);
83+
84+
const releaseDataEntry = extractReleaseData(
85+
releases[id].title + '\n' + releases[id].abstract[0].text,
86+
);
8387

8488
if (!releaseDataEntry) {
8589
console.warn(

0 commit comments

Comments
 (0)