-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Open
Labels
enhancementImproves an existing repo feature.Improves an existing repo feature.idleIssues and pull requests with no activity for three months.Issues and pull requests with no activity for three months.
Description
This repo has an .eslintrc, added in #244: https://github.com/mdn/webextensions-examples/blob/main/.eslintrc.json
... but it is stuck in 2017 and it doesn't appear to be enforced (evidenced by the plenty of failures when I run the following from the root of the repo:
npm install
npm test # this is equivalent to: ./node_modules/.bin/eslintrc .eslint used to be run in CI, but for some unknown reason it was dropped in #259.
We should re-enable CI. Move to Github Actions instead of Travis CI, because Travis CI is no longer free and most mdn/Mozilla projects have switched already.
Task list:
- Update eslint to latest version, by bumping:
webextensions-examples/package.json
Line 7 in 9433f84
"eslint": "^4.4.1" - Update .eslintrc to support modern syntax and APIs.
- Resolve or suppress linter warnings when
npm testis run. - Replace the Travis with Github actions: https://docs.github.com/en/actions/migrating-to-github-actions/manual-migrations/migrating-from-travis-ci-to-github-actions
Metadata
Metadata
Assignees
Labels
enhancementImproves an existing repo feature.Improves an existing repo feature.idleIssues and pull requests with no activity for three months.Issues and pull requests with no activity for three months.