add error handlint to add_subgroup function; add function to delete subgroup

Author: sszepe

dspace_rest_client/client.py

@@ -1677,7 +1677,62 @@ def add_subgroup(self, parent_uuid, child_uuid):
         headers = {"Content-Type": "text/uri-list"}
         data = f"{self.API_ENDPOINT}/eperson/groups/{child_uuid}"
         response = self.api_post(url, headers=headers, data=data)
-        return response.status_code == 204
+        if response.status_code == 204:
+            return True
+        elif response.status_code == 401:
+            logging.error("You are not authenticated")
+            return False
+        elif response.status_code == 403:
+            logging.error("You are not logged in with sufficient permissions")
+            return False
+        elif response.status_code == 404:
+            logging.error("The parent group doesn't exist")
+            return False
+        elif response.status_code == 422:
+            logging.error(
+                "The specified group is not found, or if adding the group would create a cyclic reference"
+            )
+            return False
+        else:
+            logging.error(
+                "Failed to add subgroup %s to group %s: %s",
+                child_uuid,
+                parent_uuid,
+                response.text,
+            )
+            return False
+
+    def remove_subgroup(self, parent_uuid, child_uuid):
+        """
+        Remove a subgroup from a parent group
+        @param parent_uuid: UUID of the parent group
+        @param child_uuid: UUID of the subgroup to remove
+        @return: Boolean indicating success or failure
+        """
+        url = f"{self.API_ENDPOINT}/eperson/groups/{parent_uuid}/subgroups/{child_uuid}"
+        response = self.api_delete(url)
+        if response.status_code == 204:
+            return True
+        if response.status_code == 401:
+            logging.error("You are not authenticated")
+            return False
+        elif response.status_code == 403:
+            logging.error("You are not logged in with sufficient permissions")
+            return False
+        elif response.status_code == 404:
+            logging.error("The parent group doesn't exist")
+            return False
+        elif response.status_code == 422:
+            logging.error("The specified group is not found")
+            return False
+        else:
+            logging.error(
+                "Failed to remove subgroup %s from group %s: %s",
+                child_uuid,
+                parent_uuid,
+                response.text,
+            )
+            return False
 
     def start_workflow(self, workspace_item):
         url = f"{self.API_ENDPOINT}/workflow/workflowitems"