chore: upgrade (dev)Dependencies, prepare for eslint 8

Author: JounQin

codechecks.yml

@@ -16,7 +16,7 @@
     "clean": "rimraf packages/*/{lib,*.tsbuildinfo} node_modules/@1stg/eslint-config/node_modules",
     "lint": "run-p lint:*",
     "lint:es": "eslint . --cache -f friendly",
-    "lint:ts": "tslint -p . -t stylish",
+    "lint:tsc": "tsc --noEmit",
     "postinstall": "simple-git-hooks && yarn-deduplicate --strategy fewer || exit 0",
     "prelint": "yarn build",
     "prerelease": "yarn build",
@@ -25,28 +25,26 @@
     "typecov": "type-coverage"
   },
   "devDependencies": {
-    "@1stg/lib-config": "^3.0.0",
-    "@1stg/tslint-config": "^2.1.0",
-    "@types/eslint": "^7.28.0",
+    "@1stg/lib-config": "^4.1.2",
+    "@types/eslint": "^7.28.1",
     "@types/eslint-plugin-markdown": "^2.0.0",
-    "@types/jest": "^27.0.1",
-    "@types/node": "^16.7.1",
-    "@types/react": "^17.0.19",
+    "@types/jest": "^27.0.2",
+    "@types/node": "^16.10.9",
+    "@types/react": "^17.0.29",
     "@types/unist": "^2.0.6",
     "lerna": "^4.0.0",
     "npm-run-all": "^4.1.5",
     "react": "^17.0.2",
     "remark-frontmatter": "2",
     "remark-validate-links": "^10.0.4",
     "ts-jest": "^27.0.5",
-    "ts-node": "^10.2.1",
-    "tslint": "^6.1.3",
+    "ts-node": "^10.3.0",
     "type-coverage": "^2.18.2",
-    "typescript": "^4.3.5",
+    "typescript": "^4.4.4",
     "yarn-deduplicate": "^3.1.0"
   },
   "resolutions": {
-    "prettier": "^2.3.2"
+    "prettier": "^2.4.1"
   },
   "commitlint": {
     "extends": [

package.json

@@ -157,12 +157,14 @@ export class Parser {
 
   parseForESLint(code: string, options: ParserOptions) {
     const extname = path.extname(options.filePath)
-    const isMdx = DEFAULT_EXTENSIONS.concat(options.extensions || []).includes(
-      extname,
-    )
-    const isMarkdown = MARKDOWN_EXTENSIONS.concat(
-      options.markdownExtensions || [],
-    ).includes(extname)
+    const isMdx = [
+      ...DEFAULT_EXTENSIONS,
+      ...(options.extensions || []),
+    ].includes(extname)
+    const isMarkdown = [
+      ...MARKDOWN_EXTENSIONS,
+      ...(options.markdownExtensions || []),
+    ].includes(extname)
     if (!isMdx && !isMarkdown) {
       return this._eslintParse(code, options)
     }

packages/eslint-mdx/src/parser.ts

@@ -33,8 +33,8 @@
   },
   "dependencies": {
     "eslint-mdx": "^1.15.1",
-    "eslint-plugin-markdown": "^2.2.0",
-    "synckit": "^0.3.4",
+    "eslint-plugin-markdown": "^2.2.1",
+    "synckit": "^0.4.1",
     "tslib": "^2.3.1",
     "vfile": "^4.2.1"
   }

packages/eslint-plugin-mdx/package.json

@@ -12,6 +12,7 @@ import { createSyncFn } from 'synckit'
 import type { FrozenProcessor } from 'unified'
 import type { VFile, VFileOptions } from 'vfile'
 import vfile from 'vfile'
+import type { VFileMessage } from 'vfile-message'
 
 import type { RemarkLintMessage } from './types'
 
@@ -48,12 +49,14 @@ export const remark: Rule.RuleModule = {
     const extname = path.extname(filename)
     const sourceCode = context.getSourceCode()
     const options = context.parserOptions as ParserOptions
-    const isMdx = DEFAULT_EXTENSIONS.concat(options.extensions || []).includes(
-      extname,
-    )
-    const isMarkdown = MARKDOWN_EXTENSIONS.concat(
-      options.markdownExtensions || [],
-    ).includes(extname)
+    const isMdx = [
+      ...DEFAULT_EXTENSIONS,
+      ...(options.extensions || []),
+    ].includes(extname)
+    const isMarkdown = [
+      ...MARKDOWN_EXTENSIONS,
+      ...(options.markdownExtensions || []),
+    ].includes(extname)
     return {
       // eslint-disable-next-line sonarjs/cognitive-complexity
       Program(node) {
@@ -102,8 +105,11 @@ export const remark: Rule.RuleModule = {
               )
               file.messages = messages
               fixedText = content
-            } else if (!file.messages.includes(err)) {
-              file.message(err).fatal = true
+            } else if (!file.messages.includes(err as VFileMessage)) {
+              file.message(
+                // @ts-expect-error Error is fine
+                err,
+              ).fatal = true
             }
           }
         }

packages/eslint-plugin-mdx/src/rules/remark.ts

@@ -2,6 +2,7 @@ import { getRemarkProcessor } from 'eslint-mdx'
 import { runAsWorker } from 'synckit'
 import type { VFileOptions } from 'vfile'
 import vfile from 'vfile'
+import type { VFileMessage } from 'vfile-message'
 
 runAsWorker(
   async (
@@ -14,8 +15,11 @@ runAsWorker(
     try {
       await remarkProcessor.process(file)
     } catch (err) {
-      if (!file.messages.includes(err)) {
-        file.message(err).fatal = true
+      if (!file.messages.includes(err as VFileMessage)) {
+        file.message(
+          // @ts-expect-error Error is fine
+          err,
+        ).fatal = true
       }
     }
     return {

packages/eslint-plugin-mdx/src/worker.ts

@@ -1,8 +1,8 @@
+import { parser, ruleTester } from './helpers'
+
 import { DEFAULT_PARSER_OPTIONS as parserOptions } from 'eslint-mdx'
 import { noUnusedExpressions } from 'eslint-plugin-mdx'
 
-import { parser, ruleTester } from './helpers'
-
 ruleTester.run('no-unused-expressions', noUnusedExpressions, {
   valid: [
     {

test/no-unused-expressions.test.ts

@@ -1,4 +1,6 @@
 /* eslint-disable sonarjs/no-duplicate-string */
+import { noop } from './helpers'
+
 import type { Node, Parent, ParserConfig, ParserOptions } from 'eslint-mdx'
 import {
   DEFAULT_PARSER_OPTIONS as parserOptions,
@@ -9,8 +11,6 @@ import {
   parser,
 } from 'eslint-mdx'
 
-import { noop } from './helpers'
-
 const stringToNode = (text: string) =>
   first(
     (getRemarkProcessor(PLACEHOLDER_FILE_PATH, true).parse(text) as Parent)

test/parser.test.ts

@@ -1,15 +1,15 @@
+import { homedir } from 'os'
 import path from 'path'
 
+import { parser, ruleTester } from './helpers'
+
 import {
   DEFAULT_PARSER_OPTIONS as parserOptions,
   // eslint-disable-next-line @typescript-eslint/prefer-ts-expect-error
   // @ts-ignore
   processorCache,
 } from 'eslint-mdx'
 import { remark } from 'eslint-plugin-mdx'
-import { homedir } from 'os'
-
-import { parser, ruleTester } from './helpers'
 
 const userDir = homedir()