feat: call creatSyncFn lazily for performance (#324)

Author: JounQin

package.json

@@ -15,7 +15,7 @@
     "build:ts": "tsc -b",
     "clean": "rimraf packages/*/{lib,*.tsbuildinfo} node_modules/@1stg/eslint-config/node_modules",
     "lint": "run-p lint:*",
-    "lint:es": "cross-env PARSER_NO_WATCH=true eslint . --cache --ext js,md,ts -f friendly",
+    "lint:es": "eslint . --cache -f friendly",
     "lint:ts": "tslint -p . -t stylish",
     "postinstall": "simple-git-hooks && yarn-deduplicate --strategy fewer || exit 0",
     "prelint": "yarn build",
@@ -30,15 +30,15 @@
     "@types/eslint": "^7.2.14",
     "@types/eslint-plugin-markdown": "^2.0.0",
     "@types/jest": "^26.0.24",
-    "@types/node": "^16.3.0",
+    "@types/node": "^16.3.1",
     "@types/react": "^17.0.14",
     "@types/unist": "^2.0.5",
     "lerna": "^4.0.0",
     "npm-run-all": "^4.1.5",
     "react": "^17.0.2",
     "remark-validate-links": "^10.0.4",
     "ts-jest": "^27.0.3",
-    "ts-node": "^10.0.0",
+    "ts-node": "^10.1.0",
     "tslint": "^6.1.3",
     "type-coverage": "^2.18.0",
     "typescript": "^4.3.5",

packages/eslint-plugin-mdx/src/rules/remark.ts

@@ -11,13 +11,18 @@ import vfile from 'vfile'
 import { getPhysicalFilename, getRemarkProcessor } from './helpers'
 import type { RemarkLintMessage } from './types'
 
-const processSync = createSyncFn(require.resolve('../worker')) as (
-  fileOptions: VFileOptions,
-  physicalFilename: string,
-  isFile: boolean,
-) => {
-  messages: VFile['messages']
-  content: string
+// call `creatSyncFn` lazily for performance, it is already cached inside, related #323
+const lazyRemark = {
+  get processSync() {
+    return createSyncFn(require.resolve('../worker')) as (
+      fileOptions: VFileOptions,
+      physicalFilename: string,
+      isMdx: boolean,
+    ) => {
+      messages: VFile['messages']
+      content: string
+    }
+  },
 }
 
 const brokenCache = new WeakMap<FrozenProcessor, true>()
@@ -67,7 +72,7 @@ export const remark: Rule.RuleModule = {
         let broken = brokenCache.get(remarkProcessor)
 
         if (broken) {
-          const { messages, content } = processSync(
+          const { messages, content } = lazyRemark.processSync(
             fileOptions,
             physicalFilename,
             isMdx,
@@ -84,7 +89,7 @@ export const remark: Rule.RuleModule = {
               '`processSync` finished async. Use `process` instead'
             ) {
               brokenCache.set(remarkProcessor, (broken = true))
-              const { messages, content } = processSync(
+              const { messages, content } = lazyRemark.processSync(
                 fileOptions,
                 physicalFilename,
                 isMdx,

yarn.lock

@@ -3076,10 +3076,10 @@
   resolved "https://registry.yarnpkg.com/@types/minimist/-/minimist-1.2.1.tgz#283f669ff76d7b8260df8ab7a4262cc83d988256"
   integrity sha512-fZQQafSREFyuZcdWFAExYjBiCL7AUCdgsk80iO0q4yihYYdcIiH28CcuPTGFgLOCC8RlW49GSQxdHwZP+I7CNg==
 
-"@types/node@*", "@types/node@^16.3.0":
-  version "16.3.0"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-16.3.0.tgz#1836664e4fad13b51b07eb6e882a53925e6543c4"
-  integrity sha512-OydMCocGMGqw/1BnWbhtK+AtwyWTOigtrQlRe57OQmTNcI3HKlVI5FGlh+c4mSqInMPLynFrTlYjfajPu9O/eQ==
+"@types/node@*", "@types/node@^16.3.1":
+  version "16.3.1"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-16.3.1.tgz#24691fa2b0c3ec8c0d34bfcfd495edac5593ebb4"
+  integrity sha512-N87VuQi7HEeRJkhzovao/JviiqKjDKMVKxKMfUvSKw+MbkbW8R0nA3fi/MQhhlxV2fQ+2ReM+/Nt4efdrJx3zA==
 
 "@types/normalize-package-data@^2.4.0":
   version "2.4.0"
@@ -11749,10 +11749,10 @@ ts-jest@^27.0.3:
     semver "7.x"
     yargs-parser "20.x"
 
-ts-node@^10.0.0:
-  version "10.0.0"
-  resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-10.0.0.tgz#05f10b9a716b0b624129ad44f0ea05dac84ba3be"
-  integrity sha512-ROWeOIUvfFbPZkoDis0L/55Fk+6gFQNZwwKPLinacRl6tsxstTF1DbAcLKkovwnpKMVvOMHP1TIbnwXwtLg1gg==
+ts-node@^10.1.0:
+  version "10.1.0"
+  resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-10.1.0.tgz#e656d8ad3b61106938a867f69c39a8ba6efc966e"
+  integrity sha512-6szn3+J9WyG2hE+5W8e0ruZrzyk1uFLYye6IGMBadnOzDh8aP7t8CbFpsfCiEx2+wMixAhjFt7lOZC4+l+WbEA==
   dependencies:
     "@tsconfig/node10" "^1.0.7"
     "@tsconfig/node12" "^1.0.7"