Skip to content

Commit 80686eb

Browse files
committed
feat: catch remark process error
1 parent a16ebb0 commit 80686eb

File tree

5 files changed

+1360
-1279
lines changed

5 files changed

+1360
-1279
lines changed

package.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@
2727
"type-coverage": "type-coverage --cache --detail --ignore-catch --ignore-files '**/*.d.ts' --strict"
2828
},
2929
"devDependencies": {
30-
"@1stg/lib-config": "^0.4.5",
31-
"@1stg/tslint-config": "^0.8.3",
30+
"@1stg/lib-config": "^0.5.1",
31+
"@1stg/tslint-config": "^0.8.4",
3232
"@types/eslint": "^6.8.0",
3333
"@types/jest": "^25.2.1",
34-
"@types/node": "^13.13.0",
34+
"@types/node": "^13.13.4",
3535
"@types/react": "^16.9.34",
3636
"@types/rebass": "^4.0.5",
3737
"@types/unist": "^2.0.3",
@@ -42,15 +42,15 @@
4242
"npm-run-all": "^4.1.5",
4343
"react": "^16.13.1",
4444
"ts-jest": "^25.4.0",
45-
"ts-node": "^8.8.2",
46-
"tslint": "^6.1.1",
45+
"ts-node": "^8.9.1",
46+
"tslint": "^6.1.2",
4747
"type-coverage": "^2.4.2",
4848
"yarn-deduplicate": "^2.0.0"
4949
},
5050
"resolutions": {
51-
"@babel/core": "^7.9.0",
52-
"@babel/preset-env": "^7.9.5",
53-
"eslint-plugin-prettier": "^3.1.3",
51+
"@babel/core": "^7.9.6",
52+
"@babel/preset-env": "^7.9.6",
53+
"@types/estree": "^0.0.44",
5454
"typescript": "^3.8.3"
5555
},
5656
"commitlint": {

packages/eslint-mdx/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
},
3535
"dependencies": {
3636
"espree": "^6.2.1",
37-
"remark-mdx": "^1.5.8",
38-
"remark-parse": "^8.0.1",
37+
"remark-mdx": "^1.6.0",
38+
"remark-parse": "^8.0.2",
3939
"tslib": "^1.11.1",
4040
"unified": "^9.0.0"
4141
}

packages/eslint-plugin-mdx/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
"cosmiconfig": "^6.0.0",
3737
"eslint-mdx": "^1.6.9",
3838
"eslint-plugin-react": "^7.19.0",
39-
"remark-mdx": "^1.5.8",
40-
"remark-parse": "^8.0.1",
39+
"remark-mdx": "^1.6.0",
40+
"remark-parse": "^8.0.2",
4141
"remark-stringify": "^8.0.0",
4242
"tslib": "^1.11.1",
4343
"unified": "^9.0.0",

packages/eslint-plugin-mdx/src/rules/remark.ts

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,20 @@ export const remark: Rule.RuleModule = {
3737
}
3838
const sourceText = sourceCode.getText(node)
3939
const remarkProcessor = getRemarkProcessor(filename)
40-
const file = remarkProcessor.processSync(
41-
vfile({
42-
path: filename,
43-
contents: sourceText,
44-
}),
45-
)
40+
const file = vfile({
41+
path: filename,
42+
contents: sourceText,
43+
})
44+
45+
try {
46+
remarkProcessor.processSync(file)
47+
} catch (err) {
48+
/* istanbul ignore next */
49+
if (!file.messages.includes(err)) {
50+
file.message(err).fatal = true
51+
}
52+
}
53+
4654
file.messages.forEach(
4755
({ source, reason, ruleId, location: { start, end } }) =>
4856
context.report({

0 commit comments

Comments
 (0)