ci: skip publish on CI automatically

Author: JounQin

.travis.yml

@@ -38,11 +38,11 @@ before_deploy:
   - lerna-changelog
 
 deploy:
-  - provider: script
-    skip_cleanup: true
-    script: yarn lerna publish --create-release github --yes
-    on:
-      branch: master
+  # - provider: script
+  #   skip_cleanup: true
+  #   script: yarn lerna publish --create-release github --yes
+  #   on:
+  #     branch: master
   - provider: script
     skip_cleanup: true
     script: yarn lerna publish --canary --conventional-prerelease --force-publish --preid beta --pre-dist-tag beta --yes

package.json

@@ -21,34 +21,35 @@
     "prelint": "yarn build",
     "prepublishOnly": "yarn build",
     "pretest": "yarn clean",
+    "publish": "lerna publish --create-release github --yes",
     "test": "ts-node --skip-ignore node_modules/.bin/jest",
     "type-coverage": "type-coverage --cache --detail --ignore-catch --ignore-files *.d.ts --strict"
   },
   "devDependencies": {
-    "@1stg/lib-config": "^0.1.15",
-    "@1stg/tslint-config": "^0.5.7",
-    "@types/eslint": "^6.1.3",
-    "@types/jest": "^24.0.23",
-    "@types/node": "^12.12.18",
-    "@types/react": "^16.9.16",
-    "@types/rebass": "^4.0.3",
+    "@1stg/lib-config": "^0.1.19",
+    "@1stg/tslint-config": "^0.5.8",
+    "@types/eslint": "^6.1.7",
+    "@types/jest": "^24.9.1",
+    "@types/node": "^13.5.0",
+    "@types/react": "^16.9.19",
+    "@types/rebass": "^4.0.4",
     "@types/unist": "^2.0.3",
     "cosmiconfig": "^6.0.0",
     "eslint-mdx": "link:packages/eslint-mdx/src",
     "eslint-plugin-mdx": "link:packages/eslint-plugin-mdx/src",
-    "lerna": "^3.19.0",
+    "lerna": "^3.20.2",
     "npm-run-all": "^4.1.5",
     "react": "^16.12.0",
-    "ts-jest": "^24.2.0",
-    "ts-node": "^8.5.4",
-    "tslint": "^5.20.1",
-    "type-coverage": "^2.3.1"
+    "ts-jest": "^25.0.0",
+    "ts-node": "^8.6.2",
+    "tslint": "^6.0.0",
+    "type-coverage": "^2.4.0"
   },
   "resolutions": {
-    "@babel/core": "^7.7.5",
-    "@babel/preset-env": "^7.7.6",
+    "@babel/core": "^7.8.3",
+    "@babel/preset-env": "^7.8.3",
     "eslint-plugin-prettier": "^3.1.2",
-    "typescript": "^3.7.3"
+    "typescript": "^3.7.5"
   },
   "commitlint": {
     "extends": [

packages/eslint-mdx/package.json

@@ -34,7 +34,7 @@
   },
   "dependencies": {
     "espree": "^6.1.2",
-    "remark-mdx": "^1.5.2",
+    "remark-mdx": "^1.5.5",
     "remark-parse": "^7.0.2",
     "tslib": "^1.10.0",
     "unified": "^8.4.2"

packages/eslint-mdx/src/parser.ts

@@ -298,7 +298,7 @@ export class Parser {
       const endOffset = range[1] - OFFSET
       nodes.push({
         type: 'jsx',
-        data: nodes.length ? null : node.data,
+        data: nodes.length > 0 ? null : node.data,
         value: value.slice(startOffset, endOffset),
         position: {
           start: {

packages/eslint-mdx/src/traverse.ts

@@ -75,7 +75,7 @@ export class Traverse {
       } else {
         acc.push(node)
       }
-      if (index === length - 1 && jsxNodes.length) {
+      if (index === length - 1 && jsxNodes.length > 0) {
         acc.push(this.combineLeftJsxNodes(jsxNodes))
       }
       return acc

packages/eslint-plugin-mdx/package.json

@@ -36,7 +36,7 @@
     "cosmiconfig": "^6.0.0",
     "eslint-mdx": "^1.6.5",
     "eslint-plugin-react": ">=7.0.0",
-    "remark-mdx": "^1.5.2",
+    "remark-mdx": "^1.5.5",
     "remark-parse": "^7.0.2",
     "remark-stringify": "^7.0.4",
     "tslib": "^1.10.0",

packages/eslint-plugin-mdx/src/rules/helper.ts

@@ -14,7 +14,7 @@ export const requirePkg = (
   prefix: string,
   filePath?: string,
 ) => {
-  if (filePath && /^\.\.?([\\/]|$)/.test(plugin)) {
+  if (filePath && /^\.\.?([/\\]|$)/.test(plugin)) {
     plugin = path.resolve(path.dirname(filePath), plugin)
   }
   prefix = prefix.endsWith('-') ? prefix : prefix + '-'

packages/eslint-plugin-mdx/src/rules/no-jsx-html-comments.ts

@@ -27,7 +27,7 @@ export const noJsxHtmlComments: Rule.RuleModule = {
           !JSX_TYPES.includes(node.expression.type as JsxType) ||
           node.parent.type !== 'Program' ||
           !invalidNodes ||
-          !invalidNodes.length
+          invalidNodes.length === 0
         ) {
           return
         }

packages/eslint-plugin-mdx/src/rules/no-unescaped-entities.ts

@@ -91,8 +91,9 @@ export const noUnescapedEntities: Rule.RuleModule = {
               end += firstLineOffset
             }
           }
-          rawLine = rawLine.substring(start, end)
+          rawLine = rawLine.slice(start, end)
           entities.forEach(entity => {
+            // eslint-disable-next-line unicorn/no-for-loop
             for (let index = 0; index < rawLine.length; index++) {
               const char = rawLine[index]
               if (typeof entity === 'string') {