chore: improve type coverage

Author: JounQin

.travis.yml

@@ -50,5 +50,5 @@ deploy:
       branch: develop
 
 after_script:
-  - yarn add -D @codechecks/client @codechecks/build-size-watcher @codechecks/type-coverage-watcher -W
+  - yarn add -D @codechecks/client @codechecks/build-size-watcher typecov -W
   - yarn codechecks

codechecks.yml

@@ -9,9 +9,10 @@ checks:
       name: 'eslint-plugin-mdx pkg size'
       files:
         - path: 'packages/eslint-plugin-mdx/lib/**/*.*'
-  - name: type-coverage-watcher
+  - name: typecov
     options:
       atLeast: 99
+      ignoreAsAssertion: true
       ignoreCatch: true
       ignoreFiles:
         - '*.d.ts'

package.json

@@ -24,27 +24,27 @@
     "pretest": "yarn clean",
     "release": "lerna publish --conventional-commits --create-release github --yes",
     "test": "ts-node --skip-ignore node_modules/.bin/jest",
-    "type-coverage": "type-coverage --cache --detail --ignore-catch --ignore-files '**/*.d.ts' --strict --update"
+    "typecov": "type-coverage"
   },
   "devDependencies": {
-    "@1stg/lib-config": "^1.0.5",
-    "@1stg/tslint-config": "^1.0.0",
+    "@1stg/lib-config": "^1.1.8",
+    "@1stg/tslint-config": "^1.0.1",
     "@types/eslint": "^7.2.6",
     "@types/jest": "^26.0.20",
     "@types/node": "^14.14.31",
     "@types/react": "^17.0.2",
-    "@types/rebass": "^4.0.7",
+    "@types/rebass": "^4.0.8",
     "@types/unist": "^2.0.3",
     "eslint-mdx": "link:packages/eslint-mdx/src",
     "eslint-plugin-mdx": "link:packages/eslint-plugin-mdx/src",
     "lerna": "^3.22.1",
     "npm-run-all": "^4.1.5",
     "react": "^17.0.1",
-    "ts-jest": "^26.5.1",
+    "ts-jest": "^26.5.2",
     "ts-node": "^9.1.1",
     "tslint": "^6.1.3",
-    "type-coverage": "^2.15.1",
-    "typescript": "^4.3.0-dev.20210220",
+    "type-coverage": "^2.16.3",
+    "typescript": "^4.2.2",
     "yarn-deduplicate": "^3.1.0"
   },
   "resolutions": {
@@ -87,6 +87,15 @@
     ]
   },
   "typeCoverage": {
-    "atLeast": 97.96
+    "atLeast": 99.37,
+    "cache": true,
+    "detail": true,
+    "ignoreAsAssertion": true,
+    "ignoreCatch": true,
+    "ignoreFiles": [
+      "**/*.d.ts"
+    ],
+    "strict": true,
+    "update": true
   }
 }

packages/eslint-mdx/package.json

@@ -37,6 +37,6 @@
     "remark-mdx": "^1.6.22",
     "remark-parse": "^8.0.3",
     "tslib": "^2.1.0",
-    "unified": "^9.1.0"
+    "unified": "^9.2.1"
   }
 }

packages/eslint-mdx/src/parser.ts

@@ -26,6 +26,7 @@ import {
   Parent,
   ParserFn,
   ParserOptions,
+  ParserServices,
 } from './types'
 
 export const mdProcessor = unified().use(remarkParse).freeze()
@@ -66,9 +67,7 @@ export class Parser {
   private _ast: AST.Program
 
   // @internal
-  private _services: {
-    JSXElementsWithHTMLComments: Node[]
-  }
+  private _services: ParserServices
 
   // @internal
   private readonly _options = DEFAULT_PARSER_OPTIONS

packages/eslint-mdx/src/types.ts

@@ -57,3 +57,7 @@ export interface Comment {
   }
   origin: string
 }
+
+export interface ParserServices {
+  JSXElementsWithHTMLComments: Node[]
+}

packages/eslint-plugin-mdx/package.json

@@ -40,7 +40,7 @@
     "remark-parse": "^8.0.3",
     "remark-stringify": "^8.1.1",
     "tslib": "^2.1.0",
-    "unified": "^9.1.0",
+    "unified": "^9.2.1",
     "vfile": "^4.2.1"
   },
   "optionalDependencies": {

packages/eslint-plugin-mdx/src/rules/no-jsx-html-comments.ts

@@ -1,5 +1,5 @@
 import { Rule } from 'eslint'
-import { Comment, JSX_TYPES, JsxType } from 'eslint-mdx'
+import { Comment, JSX_TYPES, JsxType, ParserServices } from 'eslint-mdx'
 
 import { ExpressionStatementWithParent } from './types'
 
@@ -19,9 +19,8 @@ export const noJsxHtmlComments: Rule.RuleModule = {
   create(context) {
     return {
       ExpressionStatement(node: ExpressionStatementWithParent) {
-        const invalidNodes: Array<import('unist').Node> =
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-          context.parserServices.JSXElementsWithHTMLComments
+        const invalidNodes = (context.parserServices as ParserServices)
+          .JSXElementsWithHTMLComments
 
         if (
           !JSX_TYPES.includes(node.expression.type as JsxType) ||

packages/eslint-plugin-mdx/src/rules/no-unescaped-entities.ts

@@ -38,9 +38,9 @@ const EXPRESSION = 'Literal, JSXText'
 export const noUnescapedEntities: Rule.RuleModule = {
   ...reactNoUnescapedEntities,
   create(context) {
-    const configuration: {
+    const configuration = (context.options[0] || {}) as {
       forbid?: EscapeEntity[]
-    } = context.options[0] || {}
+    }
     const entities = configuration.forbid || DEFAULTS
     return {
       // eslint-disable-next-line sonarjs/cognitive-complexity

packages/eslint-plugin-mdx/src/rules/remark.ts

@@ -23,7 +23,10 @@ export const remark: Rule.RuleModule = {
     const filename = context.getFilename()
     const extname = path.extname(filename)
     const sourceCode = context.getSourceCode()
-    const options = context.parserOptions
+    const options = context.parserOptions as {
+      extensions: string[]
+      markdownExtensions: string[]
+    }
     const isMdx = DEFAULT_EXTENSIONS.concat(options.extensions || []).includes(
       extname,
     )