fix: options unchangeable issue for default parser

Author: JounQin

.prettierignore

@@ -0,0 +1 @@
+CHANGELOG.md

.travis.yml

@@ -27,6 +27,6 @@ before_deploy:
 deploy:
   provider: script
   skip_cleanup: true
-  script: yarn deploy:pre && yarn deploy:run && yarn deploy:post || echo "nothing changed to deploy"
+  script: git tag -d v$(jq -r '.version' package.json) && yarn run run-s "deploy:*" || echo "nothing changed to deploy"
   on:
     branch: master

lerna.json

@@ -1,6 +1,6 @@
 {
   "$schema": "http://json.schemastore.org/lerna",
-  "version": "0.9.4",
+  "version": "0.9.5",
   "npmClient": "yarn",
   "useWorkspaces": true,
   "command": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-mdx",
-  "version": "0.9.4",
+  "version": "0.9.5",
   "description": "ESLint Parser/Plugin for MDX",
   "repository": "[email protected]:rx-ts/eslint-plugin-mdx.git",
   "author": "JounQin <[email protected]>",
@@ -36,6 +36,7 @@
     "jest": "^24.8.0",
     "lerna": "^3.16.4",
     "lint-staged": "^9.2.1",
+    "npm-run-all": "^4.1.5",
     "prettier": "1.18.2",
     "prettier-config-1stg": "^0.1.0",
     "react": "^16.8.6",

packages/eslint-mdx/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-mdx",
-  "version": "0.9.4",
+  "version": "0.9.5",
   "description": "ESLint Parser for MDX",
   "repository": "[email protected]:rx-ts/eslint-plugin-mdx.git",
   "author": "JounQin <[email protected]>",

packages/eslint-mdx/src/parser.ts

@@ -14,7 +14,7 @@ import {
 } from './helper'
 import { isComment, COMMENT_CONTENT_REGEX } from './regexp'
 import { traverse } from './traverse'
-import { ParserOptions, LocationError, Comment } from './types'
+import { ParserOptions, LocationError, Comment, ParserFn } from './types'
 
 import { AST, Linter } from 'eslint'
 import { Parent, Node } from 'unist'
@@ -32,29 +32,21 @@ export const LOC_ERROR_PROPERTIES = ['column', 'index', 'lineNumber'] as const
 
 export const DEFAULT_EXTENSIONS: readonly string[] = ['.mdx']
 
-export const DEFAULT_PARSER_OPTIONS: ParserOptions = {
-  ecmaFeatures: { jsx: true },
-  ecmaVersion: new Date().getUTCFullYear() as Linter.ParserOptions['ecmaVersion'],
-  sourceType: 'module',
-}
-
 export class Parser {
   // @internal
-  private parser = normalizeParser(this.options.parser)
+  private parser: ParserFn
 
   // @internal
   private ast: AST.Program
 
   // @internal
-  private services = {
-    JSXElementsWithHTMLComments: [] as Node[],
+  private services: {
+    JSXElementsWithHTMLComments: Node[]
   }
 
   constructor(
     // @internal
-    private code = '',
-    // @internal
-    private options: ParserOptions = DEFAULT_PARSER_OPTIONS,
+    private options?: ParserOptions,
   ) {
     this.parse = this.parse.bind(this)
     this.parseForESLint = this.parseForESLint.bind(this)
@@ -132,29 +124,34 @@ export class Parser {
     return this.normalizeJsxNodes(node)
   }
 
-  parse(code = this.code, options = this.options) {
+  parse(code: string, options: ParserOptions) {
     return this.parseForESLint(code, options).ast
   }
 
-  parseForESLint(code = this.code, options = this.options) {
+  parseForESLint(code: string, options: ParserOptions) {
+    this.options = options
+
     if (
-      !DEFAULT_EXTENSIONS.concat(this.options.extensions || []).includes(
+      !DEFAULT_EXTENSIONS.concat(options.extensions || []).includes(
         path.extname(options.filePath),
       )
     ) {
       return this.eslintParse(code, options)
     }
 
-    const root = mdxProcessor.parse(this.code) as Parent
+    const root = mdxProcessor.parse(code) as Parent
 
     this.ast = {
       ...normalizePosition(root.position),
       type: 'Program',
-      sourceType: this.options.sourceType || 'module',
+      sourceType: options.sourceType || 'module',
       body: [],
       comments: [],
       tokens: [],
     }
+    this.services = {
+      JSXElementsWithHTMLComments: [],
+    }
 
     traverse(root, {
       enter: (node, parent) => {
@@ -175,7 +172,11 @@ export class Parser {
   }
 
   // @internal
-  private eslintParse(code = this.code, options = this.options) {
+  private eslintParse(code: string, options = this.options) {
+    if (!this.parser || options !== this.options) {
+      this.options = options
+      this.parser = normalizeParser(options.parser)
+    }
     const program = this.parser(code, options)
     return ('ast' in program && program.ast
       ? program

packages/eslint-plugin-mdx/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rxts/eslint-plugin-mdx",
-  "version": "0.9.4",
+  "version": "0.9.5",
   "description": "ESLint Plugin for MDX",
   "repository": "[email protected]:rx-ts/eslint-plugin-mdx.git",
   "author": "JounQin <[email protected]>",
@@ -21,7 +21,7 @@
     "eslint": ">=5.0.0"
   },
   "dependencies": {
-    "eslint-mdx": "^0.9.3",
+    "eslint-mdx": "^0.9.5",
     "remark-mdx": "^1.1.5",
     "remark-parse": "^7.0.0",
     "unified": "^8.3.2"

test/helper.ts

@@ -0,0 +1,13 @@
+import { ParserOptions, Parser } from 'eslint-mdx'
+
+import { Linter } from 'eslint'
+
+export const DEFAULT_PARSER_OPTIONS: ParserOptions = {
+  ecmaFeatures: {
+    jsx: true,
+  },
+  ecmaVersion: new Date().getUTCFullYear() as Linter.ParserOptions['ecmaVersion'],
+  sourceType: 'module',
+}
+
+export const parser = new Parser(DEFAULT_PARSER_OPTIONS)

test/parser.test.ts

@@ -1,4 +1,6 @@
-import { first, mdxProcessor, parser } from 'eslint-mdx'
+import { first, mdxProcessor } from 'eslint-mdx'
+
+import { parser } from './helper'
 
 import { Node } from 'unist'
 

yarn.lock

@@ -1680,6 +1680,11 @@ array-equal@^1.0.0:
   resolved "https://registry.yarnpkg.com/array-equal/-/array-equal-1.0.0.tgz#8c2a5ef2472fd9ea742b04c77a75093ba2757c93"
   integrity sha1-jCpe8kcv2ep0KwTHenUJO6J1fJM=
 
+array-filter@~0.0.0:
+  version "0.0.1"
+  resolved "https://registry.yarnpkg.com/array-filter/-/array-filter-0.0.1.tgz#7da8cf2e26628ed732803581fd21f67cacd2eeec"
+  integrity sha1-fajPLiZijtcygDWB/SH2fKzS7uw=
+
 array-find-index@^1.0.1:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/array-find-index/-/array-find-index-1.0.2.tgz#df010aa1287e164bbda6f9723b0a96a1ec4187a1"
@@ -1698,6 +1703,16 @@ array-includes@^3.0.3:
     define-properties "^1.1.2"
     es-abstract "^1.7.0"
 
+array-map@~0.0.0:
+  version "0.0.0"
+  resolved "https://registry.yarnpkg.com/array-map/-/array-map-0.0.0.tgz#88a2bab73d1cf7bcd5c1b118a003f66f665fa662"
+  integrity sha1-iKK6tz0c97zVwbEYoAP2b2ZfpmI=
+
+array-reduce@~0.0.0:
+  version "0.0.0"
+  resolved "https://registry.yarnpkg.com/array-reduce/-/array-reduce-0.0.0.tgz#173899d3ffd1c7d9383e4479525dbe278cab5f2b"
+  integrity sha1-FziZ0//Rx9k4PkR5Ul2+J4yrXys=
+
 array-union@^1.0.2:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/array-union/-/array-union-1.0.2.tgz#9a34410e4f4e3da23dea375be5be70f24778ec39"
@@ -2937,7 +2952,7 @@ error-ex@^1.2.0, error-ex@^1.3.1:
   dependencies:
     is-arrayish "^0.2.1"
 
-es-abstract@^1.11.0, es-abstract@^1.12.0, es-abstract@^1.5.1, es-abstract@^1.7.0:
+es-abstract@^1.11.0, es-abstract@^1.12.0, es-abstract@^1.4.3, es-abstract@^1.5.1, es-abstract@^1.7.0:
   version "1.13.0"
   resolved "https://registry.yarnpkg.com/es-abstract/-/es-abstract-1.13.0.tgz#ac86145fdd5099d8dd49558ccba2eaf9b88e24e9"
   integrity sha512-vDZfg/ykNxQVwup/8E1BZhVzFfBxs9NqMzGcvIJrqg5k2/5Za2bWo40dK2J1pgLngZ7c+Shh8lwYtLGyrwPutg==
@@ -3633,7 +3648,7 @@ fsevents@^1.2.7:
     nan "^2.12.1"
     node-pre-gyp "^0.12.0"
 
-function-bind@^1.1.1:
+function-bind@^1.0.2, function-bind@^1.1.1:
   version "1.1.1"
   resolved "https://registry.yarnpkg.com/function-bind/-/function-bind-1.1.1.tgz#a56899d3ea3c9bab874bb9773b7c5ede92f4895d"
   integrity sha512-yIovAzMX49sF8Yl58fSCWJ5svSLuaibPxXQJFLmBObTuCr0Mf1KiPopGM9NiFjiYBCbfaa2Fh6breQ6ANVTI0A==
@@ -5022,6 +5037,11 @@ jsonfile@^4.0.0:
   optionalDependencies:
     graceful-fs "^4.1.6"
 
+jsonify@~0.0.0:
+  version "0.0.0"
+  resolved "https://registry.yarnpkg.com/jsonify/-/jsonify-0.0.0.tgz#2c74b6ee41d93ca51b7b5aaee8f503631d252a73"
+  integrity sha1-LHS27kHZPKUbe1qu6PUDYx0lKnM=
+
 jsonparse@^1.2.0:
   version "1.3.1"
   resolved "https://registry.yarnpkg.com/jsonparse/-/jsonparse-1.3.1.tgz#3f4dae4a91fac315f71062f8521cc239f1366280"
@@ -5457,6 +5477,11 @@ mem@^4.0.0:
     mimic-fn "^2.0.0"
     p-is-promise "^2.0.0"
 
+memorystream@^0.3.1:
+  version "0.3.1"
+  resolved "https://registry.yarnpkg.com/memorystream/-/memorystream-0.3.1.tgz#86d7090b30ce455d63fbae12dda51a47ddcaf9b2"
+  integrity sha1-htcJCzDORV1j+64S3aUaR93K+bI=
+
 [email protected]:
   version "5.0.0"
   resolved "https://registry.yarnpkg.com/meow/-/meow-5.0.0.tgz#dfc73d63a9afc714a5e371760eb5c88b91078aa4"
@@ -5905,6 +5930,21 @@ npm-pick-manifest@^2.2.3:
     npm-package-arg "^6.0.0"
     semver "^5.4.1"
 
+npm-run-all@^4.1.5:
+  version "4.1.5"
+  resolved "https://registry.yarnpkg.com/npm-run-all/-/npm-run-all-4.1.5.tgz#04476202a15ee0e2e214080861bff12a51d98fba"
+  integrity sha512-Oo82gJDAVcaMdi3nuoKFavkIHBRVqQ1qvMb+9LHk/cF4P6B2m8aP04hGf7oL6wZ9BuGwX1onlLhpuoofSyoQDQ==
+  dependencies:
+    ansi-styles "^3.2.1"
+    chalk "^2.4.1"
+    cross-spawn "^6.0.5"
+    memorystream "^0.3.1"
+    minimatch "^3.0.4"
+    pidtree "^0.3.0"
+    read-pkg "^3.0.0"
+    shell-quote "^1.6.1"
+    string.prototype.padend "^3.0.0"
+
 npm-run-path@^2.0.0:
   version "2.0.2"
   resolved "https://registry.yarnpkg.com/npm-run-path/-/npm-run-path-2.0.2.tgz#35a9232dfa35d7067b4cb2ddf2357b1871536c5f"
@@ -6395,6 +6435,11 @@ picomatch@^2.0.5:
   resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.0.7.tgz#514169d8c7cd0bdbeecc8a2609e34a7163de69f6"
   integrity sha512-oLHIdio3tZ0qH76NybpeneBhYVj0QFTfXEFTc/B3zKQspYfYYkWYgFsmzo+4kvId/bQRcNkVeguI3y+CD22BtA==
 
+pidtree@^0.3.0:
+  version "0.3.0"
+  resolved "https://registry.yarnpkg.com/pidtree/-/pidtree-0.3.0.tgz#f6fada10fccc9f99bf50e90d0b23d72c9ebc2e6b"
+  integrity sha512-9CT4NFlDcosssyg8KVFltgokyKZIFjoBxw8CTGy+5F38Y1eQWrt8tRayiUOXE+zVKQnYu5BR8JjCtvK3BcnBhg==
+
 pify@^2.0.0, pify@^2.3.0:
   version "2.3.0"
   resolved "https://registry.yarnpkg.com/pify/-/pify-2.3.0.tgz#ed141a6ac043a849ea588498e7dca8b15330e90c"
@@ -7190,6 +7235,16 @@ shebang-regex@^1.0.0:
   resolved "https://registry.yarnpkg.com/shebang-regex/-/shebang-regex-1.0.0.tgz#da42f49740c0b42db2ca9728571cb190c98efea3"
   integrity sha1-2kL0l0DAtC2yypcoVxyxkMmO/qM=
 
+shell-quote@^1.6.1:
+  version "1.6.1"
+  resolved "https://registry.yarnpkg.com/shell-quote/-/shell-quote-1.6.1.tgz#f4781949cce402697127430ea3b3c5476f481767"
+  integrity sha1-9HgZSczkAmlxJ0MOo7PFR29IF2c=
+  dependencies:
+    array-filter "~0.0.0"
+    array-map "~0.0.0"
+    array-reduce "~0.0.0"
+    jsonify "~0.0.0"
+
 shellwords@^0.1.1:
   version "0.1.1"
   resolved "https://registry.yarnpkg.com/shellwords/-/shellwords-0.1.1.tgz#d6b9181c1a48d397324c84871efbcfc73fc0654b"
@@ -7500,6 +7555,15 @@ string-width@^3.0.0, string-width@^3.1.0:
     is-fullwidth-code-point "^2.0.0"
     strip-ansi "^5.1.0"
 
+string.prototype.padend@^3.0.0:
+  version "3.0.0"
+  resolved "https://registry.yarnpkg.com/string.prototype.padend/-/string.prototype.padend-3.0.0.tgz#f3aaef7c1719f170c5eab1c32bf780d96e21f2f0"
+  integrity sha1-86rvfBcZ8XDF6rHDK/eA2W4h8vA=
+  dependencies:
+    define-properties "^1.1.2"
+    es-abstract "^1.4.3"
+    function-bind "^1.0.2"
+
 string_decoder@^1.1.1:
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/string_decoder/-/string_decoder-1.2.0.tgz#fe86e738b19544afe70469243b2a1ee9240eae8d"