feat: bump all upgradable deps, fix related usage (#321)

Author: JounQin

.codesandbox/ci.json

@@ -1,4 +1,5 @@
 {
+  "node": "14",
   "packages": [
     "packages/*"
   ],

.eslintrc.js

@@ -5,30 +5,17 @@ module.exports = {
     // `strictNullChecks` is required
     '@typescript-eslint/no-unnecessary-condition': 0,
   },
-  settings: {
-    node: {
-      allowModules: ['@babel/types', 'estree', 'unist'],
-    },
-  },
   overrides: [
     {
       files: '*.ts',
       rules: {
         '@typescript-eslint/consistent-type-imports': 2,
       },
     },
-    {
-      files: '**/*.{md,mdx}/**',
-      rules: {
-        'unicorn/filename-case': 0,
-      },
-    },
     {
       files: '*.{md,mdx}',
       rules: {
         'react/no-unescaped-entities': 1,
-        // related to https://github.com/eslint/eslint/issues/14207
-        'unicorn/filename-case': 0,
       },
       settings: {
         'mdx/code-blocks': true,

package.json

@@ -25,29 +25,29 @@
     "typecov": "type-coverage"
   },
   "devDependencies": {
-    "@1stg/lib-config": "^1.2.10",
-    "@1stg/tslint-config": "^1.2.0",
-    "@types/eslint": "^7.2.10",
+    "@1stg/lib-config": "^3.0.0",
+    "@1stg/tslint-config": "^2.0.0",
+    "@types/eslint": "^7.2.14",
     "@types/eslint-plugin-markdown": "^2.0.0",
-    "@types/jest": "^26.0.23",
-    "@types/node": "^14.14.41",
-    "@types/react": "^17.0.4",
-    "@types/unist": "^2.0.3",
+    "@types/jest": "^26.0.24",
+    "@types/node": "^16.3.0",
+    "@types/react": "^17.0.14",
+    "@types/unist": "^2.0.5",
     "lerna": "^4.0.0",
     "npm-run-all": "^4.1.5",
     "react": "^17.0.2",
     "remark-validate-links": "^10.0.4",
-    "ts-jest": "^26.5.5",
-    "ts-node": "^9.1.1",
+    "ts-jest": "^27.0.3",
+    "ts-node": "^10.0.0",
     "tslint": "^6.1.3",
-    "type-coverage": "^2.17.3",
-    "typescript": "^4.2.4",
+    "type-coverage": "^2.18.0",
+    "typescript": "^4.3.5",
     "yarn-deduplicate": "^3.1.0"
   },
   "resolutions": {
-    "@babel/core": "^7.13.16",
-    "prettier": "^2.2.1",
-    "tslib": "^2.2.0"
+    "@babel/core": "^7.14.6",
+    "prettier": "^2.3.2",
+    "tslib": "^2.3.0"
   },
   "commitlint": {
     "extends": [
@@ -89,6 +89,10 @@
         [
           2
         ]
+      ],
+      [
+        "validate-links",
+        true
       ]
     ]
   },

packages/eslint-mdx/package.json

@@ -35,7 +35,7 @@
   "dependencies": {
     "remark-mdx": "^1.6.22",
     "remark-parse": "^8.0.3",
-    "tslib": "^2.2.0",
+    "tslib": "^2.3.0",
     "unified": "^9.2.1"
   }
 }

packages/eslint-mdx/src/helpers.ts

@@ -161,6 +161,7 @@ export const arrayify = <T, R = T extends Array<infer S> ? S : T>(
     return arr
   }, [])
 
+// eslint-disable-next-line @typescript-eslint/prefer-optional-chain -- test coverage
 export const first = <T>(items: T[] | readonly T[]) => items && items[0]
 
 export const last = <T>(items: T[] | readonly T[]) =>

packages/eslint-mdx/src/parser.ts

@@ -5,7 +5,6 @@ import type { AST, Linter } from 'eslint'
 import remarkMdx from 'remark-mdx'
 import remarkParse from 'remark-parse'
 import unified from 'unified'
-import type { Node, Parent } from 'unist'
 
 import {
   arrayify,
@@ -26,6 +25,8 @@ import { traverse } from './traverse'
 import type {
   Comment,
   LocationError,
+  Node,
+  Parent,
   ParserFn,
   ParserOptions,
   ParserServices,
@@ -47,7 +48,8 @@ export const DEFAULT_PARSER_OPTIONS: ParserOptions = {
   ecmaFeatures: {
     jsx: true,
   },
-  ecmaVersion: new Date().getUTCFullYear() as Linter.ParserOptions['ecmaVersion'],
+  ecmaVersion:
+    new Date().getUTCFullYear() as Linter.ParserOptions['ecmaVersion'],
   sourceType: 'module',
   tokens: true,
   filePath: '__placeholder__.mdx',
@@ -80,7 +82,7 @@ export class Parser {
   }
 
   normalizeJsxNode(node: Node, parent?: Parent, options = this._options) {
-    const value = node.value as string
+    const value = node.value
 
     if (node.type !== 'jsx' || isComment(value)) {
       return node
@@ -235,9 +237,9 @@ export class Parser {
     }
 
     /* istanbul ignore next */
-    return ('ast' in program && program.ast
-      ? program
-      : { ast: program }) as Linter.ESLintParseResult
+    return (
+      'ast' in program && program.ast ? program : { ast: program }
+    ) as Linter.ESLintParseResult
   }
 
   // fix adjacent JSX nodes
@@ -247,7 +249,7 @@ export class Parser {
     node: Node,
     options: ParserOptions,
   ): Node | Node[] {
-    const value = node.value as string
+    const value = node.value
 
     let program: AST.Program
 
@@ -281,7 +283,7 @@ export class Parser {
       return node
     }
 
-    const { expression } = (program.body[0] as unknown) as ExpressionStatement
+    const { expression } = program.body[0] as unknown as ExpressionStatement
 
     if (!isJsxNode(expression) || expression.children.length <= 1) {
       return node
@@ -339,7 +341,7 @@ export class Parser {
       this._services.JSXElementsWithHTMLComments.push(node)
     }
 
-    const value = node.value as string
+    const value = node.value
 
     const { loc, start, end } = normalizePosition(node.position)
 

packages/eslint-mdx/src/traverse.ts

@@ -1,5 +1,3 @@
-import type { Node, Parent } from 'unist'
-
 import { arrayify, last } from './helpers'
 import { parser } from './parser'
 import {
@@ -9,7 +7,7 @@ import {
   isOpenTag,
   isSelfClosingTag,
 } from './regexp'
-import type { TraverseOptions, Traverser } from './types'
+import type { Node, Parent, TraverseOptions, Traverser } from './types'
 
 export class Traverse {
   code: string
@@ -52,7 +50,7 @@ export class Traverse {
     // eslint-disable-next-line sonarjs/cognitive-complexity
     return nodes.reduce<Node[]>((acc, node, index) => {
       if (node.type === 'jsx') {
-        const value = node.value as string
+        const value = node.value
         if (isOpenTag(value)) {
           offset++
           hasOpenTag = true
@@ -138,12 +136,10 @@ export class Traverse {
       return
     }
 
-    let children = node.children as Node[]
-
-    if (children) {
+    if ('children' in node) {
       const parent = node as Parent
-      children = node.children = this.combineJsxNodes(children, parent)
-      for (const child of children) {
+      parent.children = this.combineJsxNodes(parent.children, parent)
+      for (const child of parent.children) {
         this.traverse(child, parent)
       }
     }

packages/eslint-mdx/src/types.ts

@@ -1,6 +1,14 @@
 import type { JSXElement, JSXFragment } from '@babel/types'
 import type { AST, Linter } from 'eslint'
-import type { Node, Parent, Point } from 'unist'
+import type { Node as _Node, Parent as _Parent, Point } from 'unist'
+
+export interface Node<T = string> extends _Node {
+  value?: T
+}
+
+export interface Parent<T = string> extends _Parent {
+  children: Array<Node<T>>
+}
 
 export type Arrayable<T> = T[] | readonly T[]
 
@@ -14,7 +22,7 @@ export declare type ValueOf<T> = T extends {
   ? N
   : never
 
-export type JsxNode = (JSXElement | JSXFragment) & { range: [number, number] }
+export type JsxNode = { range: [number, number] } & (JSXElement | JSXFragment)
 
 export type ParserFn = (
   code: string,
@@ -23,10 +31,10 @@ export type ParserFn = (
 
 export type ParserConfig =
   | {
-      parseForESLint: ParserFn
+      parse: ParserFn
     }
   | {
-      parse: ParserFn
+      parseForESLint: ParserFn
     }
 
 export interface LocationError {
@@ -37,10 +45,10 @@ export interface LocationError {
 }
 
 export interface ParserOptions extends Linter.ParserOptions {
-  extensions?: string | string[]
-  markdownExtensions?: string | string[]
+  extensions?: string[] | string
+  markdownExtensions?: string[] | string
   filePath?: string
-  parser?: string | ParserConfig | ParserFn
+  parser?: ParserConfig | ParserFn | string
 }
 
 export type Traverser = (node: Node, parent?: Parent) => void

packages/eslint-mdx/typings.d.ts

@@ -1,5 +1,6 @@
 declare module 'remark-mdx' {
   import type * as unified from 'unified'
+
   const mdx: unified.Attacher
   export = mdx
 }

packages/eslint-plugin-mdx/package.json

@@ -35,12 +35,12 @@
   "dependencies": {
     "cosmiconfig": "^7.0.0",
     "eslint-mdx": "^1.13.0",
-    "eslint-plugin-markdown": "^2.1.0",
+    "eslint-plugin-markdown": "^2.2.0",
     "remark-mdx": "^1.6.22",
     "remark-parse": "^8.0.3",
     "remark-stringify": "^8.1.1",
-    "synckit": "^0.1.5",
-    "tslib": "^2.2.0",
+    "synckit": "^0.2.0",
+    "tslib": "^2.3.0",
     "unified": "^9.2.1",
     "vfile": "^4.2.1"
   }