Skip to content

Commit 95d4cdc

Browse files
Add OperatorFilterer into ERC721MOnft (#95)
* Clean up ERC721M and ERC721Onft * fix tests * Bump version from 0.0.10 to 0.0.11 * Fix comments
1 parent 10f9323 commit 95d4cdc

File tree

8 files changed

+91
-290
lines changed

8 files changed

+91
-290
lines changed

contracts/ERC721M.sol

Lines changed: 6 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -94,14 +94,6 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
9494
_;
9595
}
9696

97-
/**
98-
* @dev Returns whether NOT mintable.
99-
*/
100-
modifier cannotMint() {
101-
if (_mintable) revert Mintable();
102-
_;
103-
}
104-
10597
/**
10698
* @dev Returns whether it has enough supply for the given qty.
10799
*/
@@ -110,13 +102,6 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
110102
_;
111103
}
112104

113-
/**
114-
* @dev Returns cosigner address.
115-
*/
116-
function getCosigner() external view override returns (address) {
117-
return _cosigner;
118-
}
119-
120105
/**
121106
* @dev Returns cosign nonce.
122107
*/
@@ -132,13 +117,6 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
132117
emit SetCosigner(cosigner);
133118
}
134119

135-
/**
136-
* @dev Returns expiry in seconds.
137-
*/
138-
function getTimestampExpirySeconds() public view override returns (uint64) {
139-
return _timestampExpirySeconds;
140-
}
141-
142120
/**
143121
* @dev Sets expiry in seconds. This timestamp specifies how long a signature from cosigner is valid for.
144122
*/
@@ -147,13 +125,6 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
147125
emit SetTimestampExpirySeconds(expiry);
148126
}
149127

150-
/**
151-
* @dev Returns crossmint address.
152-
*/
153-
function getCrossmintAddress() external view override returns (address) {
154-
return _crossmintAddress;
155-
}
156-
157128
/**
158129
* @dev Sets crossmint address if using crossmint. This allows the specified address to call `crossmint`.
159130
*/
@@ -191,12 +162,11 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
191162
_mintStages.pop();
192163
}
193164

194-
uint64 timestampExpirySeconds = getTimestampExpirySeconds();
195165
for (uint256 i = 0; i < newStages.length; i++) {
196166
if (i >= 1) {
197167
if (
198168
newStages[i].startTimeUnixSeconds <
199-
newStages[i - 1].endTimeUnixSeconds + timestampExpirySeconds
169+
newStages[i - 1].endTimeUnixSeconds + _timestampExpirySeconds
200170
) {
201171
revert InsufficientStageTimeGap();
202172
}
@@ -230,7 +200,7 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
230200
/**
231201
* @dev Gets whether mintable.
232202
*/
233-
function getMintable() external view override returns (bool) {
203+
function getMintable() external view returns (bool) {
234204
return _mintable;
235205
}
236206

@@ -344,7 +314,7 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
344314
if (
345315
startTimeUnixSeconds <
346316
_mintStages[index - 1].endTimeUnixSeconds +
347-
getTimestampExpirySeconds()
317+
_timestampExpirySeconds
348318
) {
349319
revert InsufficientStageTimeGap();
350320
}
@@ -374,7 +344,7 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
374344
/**
375345
* @dev Returns mint currency address.
376346
*/
377-
function getMintCurrency() external view override returns (address) {
347+
function getMintCurrency() external view returns (address) {
378348
return _mintCurrency;
379349
}
380350

@@ -535,18 +505,6 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
535505
emit PermanentBaseURI(_currentBaseURI);
536506
}
537507

538-
/**
539-
* @dev Returns token URI suffix.
540-
*/
541-
function getTokenURISuffix()
542-
external
543-
view
544-
override
545-
returns (string memory)
546-
{
547-
return _tokenURISuffix;
548-
}
549-
550508
/**
551509
* @dev Sets token URI suffix. e.g. ".json".
552510
*/
@@ -609,7 +567,7 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
609567
uint32 qty,
610568
uint64 timestamp,
611569
bytes memory signature
612-
) public view override {
570+
) public view {
613571
if (
614572
!SignatureChecker.isValidSignatureNow(
615573
_cosigner,
@@ -625,7 +583,6 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
625583
function getActiveStageFromTimestamp(uint64 timestamp)
626584
public
627585
view
628-
override
629586
returns (uint256)
630587
{
631588
for (uint256 i = 0; i < _mintStages.length; i++) {
@@ -643,7 +600,7 @@ contract ERC721M is IERC721M, ERC721AQueryable, Ownable, ReentrancyGuard {
643600
* @dev Validates the timestamp is not expired.
644601
*/
645602
function _assertValidTimestamp(uint64 timestamp) internal view {
646-
if (timestamp < block.timestamp - getTimestampExpirySeconds())
603+
if (timestamp < block.timestamp - _timestampExpirySeconds)
647604
revert TimestampExpired();
648605
}
649606

0 commit comments

Comments
 (0)