Skip to content

Commit 4201dec

Browse files
committed
Merge branch 'master' into measure
2 parents 4a65bdc + 5283367 commit 4201dec

File tree

30 files changed

+151
-192
lines changed

30 files changed

+151
-192
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ jobs:
7373
if: false
7474
name: Sentry-Symbolicator Tests
7575
runs-on: ubuntu-latest
76+
env:
77+
USE_NEW_DEVSERVICES: 1
7678

7779
steps:
7880
- name: Install libcurl-dev
@@ -101,8 +103,8 @@ jobs:
101103
uses: ./.github/actions/setup-sentry
102104
with:
103105
workdir: sentry
104-
kafka: true
105-
snuba: true
106+
use-new-devservices: true
107+
mode: minimal
106108

107109
- name: Do the localhost docker dance
108110
run: echo "$DJANGO_LIVE_TEST_SERVER_ADDRESS host.docker.internal" | sudo tee --append /etc/hosts

.github/workflows/image.yml

Lines changed: 41 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
name: image
22
on:
33
pull_request:
4+
types: [opened, synchronize, reopened, labeled]
45
push:
56
branches:
67
- measure
@@ -11,13 +12,47 @@ concurrency:
1112
cancel-in-progress: true
1213

1314
jobs:
15+
# build-setup:
16+
# name: Setup build metadata
17+
# runs-on: ubuntu-latest
18+
19+
# env:
20+
# FULL_CI: "${{
21+
# github.event_name != 'pull_request'
22+
# || contains(github.event.pull_request.labels.*.name, 'Trigger: Full-CI')
23+
# }}"
24+
25+
# steps:
26+
# - id: set-outputs
27+
# run: |
28+
# echo "full_ci=$FULL_CI" >> $GITHUB_OUTPUT
29+
30+
# if [[ "$FULL_CI" == "true" ]]; then
31+
# echo "Running full CI"
32+
# echo 'archs=["amd64", "arm64"]' >> $GITHUB_OUTPUT
33+
# else
34+
# echo "Skipping some CI steps"
35+
# echo 'archs=["amd64"]' >> $GITHUB_OUTPUT
36+
# fi
37+
# outputs:
38+
# archs: "${{ steps.set-outputs.outputs.archs }}"
39+
# full_ci: "${{ steps.set-outputs.outputs.full_ci }}"
40+
41+
1442
build-image:
1543
permissions:
1644
packages: write
1745
strategy:
1846
matrix:
19-
arch: [amd64]
20-
runs-on: ubuntu-20.04
47+
# arch: ${{ fromJson(needs.build-setup.outputs.archs) }}
48+
arch: ["amd64", "arm64"]
49+
50+
runs-on: |-
51+
${{fromJson('{
52+
"amd64": "ubuntu-20.04",
53+
"arm64": "ubuntu-22.04-arm64-relay"
54+
}')[matrix.arch] }}
55+
2156
env:
2257
# IMG_CACHE: ghcr.io/measure-sh/symbolicator:${{ matrix.arch }}-latest
2358
IMG_VERSIONED: ghcr.io/measure-sh/symbolicator:${{ matrix.arch }}-${{ github.sha }}
@@ -27,8 +62,9 @@ jobs:
2762
- uses: actions/checkout@v4
2863
with:
2964
submodules: recursive
30-
- run: docker run --rm --privileged tonistiigi/binfmt --install arm64
31-
if: matrix.arch == 'arm64'
65+
66+
- name: Docker Login
67+
run: docker login --username '${{ github.actor }}' --password '${{ secrets.GITHUB_TOKEN }}' ghcr.io
3268

3369
- name: build builder img
3470
run: |
@@ -63,10 +99,9 @@ jobs:
6399
.
64100
65101
- name: push all images
102+
# if: "needs.build-setup.outputs.full_ci == 'true'"
66103
if: github.event_name != 'pull_request'
67104
run: |
68-
set -euxo pipefail
69-
docker login --username '${{ github.actor }}' --password '${{ secrets.GITHUB_TOKEN }}' ghcr.io
70105
docker push "$BUILDER_IMG_CACHE"
71106
docker push "$NIGHTLY_IMG_CACHE"
72107
docker push "$IMG_VERSIONED"

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
steps:
2323
- name: Get auth token
2424
id: token
25-
uses: actions/create-github-app-token@5d869da34e18e7287c1daad50e0b8ea0f506ce69 # v1.11.0
25+
uses: actions/create-github-app-token@c1a285145b9d317df6ced56c09f525b5c2b6f755 # v1.11.1
2626
with:
2727
app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
2828
private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}

CHANGELOG.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,21 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
### Dependencies
6+
7+
- Bump Native SDK from v0.7.17 to v0.7.18 ([#1596](https://github.com/getsentry/symbolicator/pull/1596))
8+
- [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#0718)
9+
- [diff](https://github.com/getsentry/sentry-native/compare/0.7.17...0.7.18)
10+
11+
## 25.1.0
12+
13+
### Dependencies
14+
15+
- Bump Native SDK from v0.7.16 to v0.7.17 ([#1573](https://github.com/getsentry/symbolicator/pull/1573))
16+
- [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#0717)
17+
- [diff](https://github.com/getsentry/sentry-native/compare/0.7.16...0.7.17)
18+
319
## 24.12.1
420

521
### Various fixes & improvements

Cargo.lock

Lines changed: 31 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ debug = 1
2525
[profile.release-lto]
2626
inherits = "release"
2727
codegen-units = 1
28-
lto = true
28+
lto = "thin"
2929

3030
[profile.local]
3131
# For running a local symbolicator, we want the best of both worlds: a fast executable, with quick
@@ -56,7 +56,7 @@ cpp_demangle = { git = "https://github.com/getsentry/cpp_demangle", branch = "se
5656

5757
[workspace.dependencies]
5858
reqwest = "0.12.2"
59-
symbolic = "12.13.1"
59+
symbolic = "12.13.2"
6060
tokio = "1.36.0"
6161
tokio-metrics = "0.3.1"
6262
tokio-util = "0.7.10"

Dockerfile

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# CLI
2-
FROM getsentry/sentry-cli:2 AS sentry-cli
2+
FROM debian:bookworm-slim AS sentry-cli
3+
4+
RUN apt-get update \
5+
&& apt-get upgrade -y \
6+
&& apt-get install -y --no-install-recommends ca-certificates curl \
7+
&& rm -rf /var/lib/apt/lists/*
8+
9+
RUN curl -sL https://sentry.io/get-cli/ | sh
310

411
# Image with cargo-chef as base image to our builder
512
FROM rust:slim-bookworm AS symbolicator-chef
@@ -41,7 +48,7 @@ RUN cp target/release-lto/symbolicator target/release-lto/symbolicator.debug \
4148
&& cp ./target/release-lto/symbolicator /usr/local/bin \
4249
&& zip /opt/symbolicator-debug.zip target/release-lto/symbolicator.debug
4350

44-
COPY --from=sentry-cli /bin/sentry-cli /bin/sentry-cli
51+
COPY --from=sentry-cli /usr/local/bin/sentry-cli /bin/sentry-cli
4552
RUN sentry-cli --version \
4653
&& SOURCE_BUNDLE="$(sentry-cli difutil bundle-sources ./target/release-lto/symbolicator.debug)" \
4754
&& mv "$SOURCE_BUNDLE" /opt/symbolicator.src.zip

0 commit comments

Comments
 (0)