fix: always set dns_config, not just for CORE_DNS (#1)

mikesmitty · web-flow · commit 2893174e787d · 2023-06-13T13:30:47.000-04:00
diff --git a/modules/beta-private-cluster-update-variant/cluster.tf b/modules/beta-private-cluster-update-variant/cluster.tf
@@ -307,7 +307,7 @@ resource "google_container_cluster" "primary" {
   }
 
   dynamic "dns_config" {
-    for_each = var.cluster_dns_provider == "CLOUD_DNS" ? [1] : []
+    for_each = var.cluster_dns_provider != "PROVIDER_UNSPECIFIED" ? [1] : []
     content {
       cluster_dns        = var.cluster_dns_provider
       cluster_dns_scope  = var.cluster_dns_scope

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ resource "google_container_cluster" "primary" {`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`dynamic "dns_config" {`
`310`		`- for_each = var.cluster_dns_provider == "CLOUD_DNS" ? [1] : []`
	`310`	`+ for_each = var.cluster_dns_provider != "PROVIDER_UNSPECIFIED" ? [1] : []`
`311`	`311`	`content {`
`312`	`312`	`cluster_dns = var.cluster_dns_provider`
`313`	`313`	`cluster_dns_scope = var.cluster_dns_scope`