Skip to content

Commit a781860

Browse files
committed
fix: configure minio-init as service_completed_successfully in compose
The minio-init init container exits after completing its setup task (exit 0). Configure it in aether-runner's depends_on with service_completed_successfully so docker compose up --wait doesn't treat the exit as a failure.
1 parent 8d23b4d commit a781860

File tree

2 files changed

+24
-21
lines changed

2 files changed

+24
-21
lines changed

.github/test/compose.yaml

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,15 @@ services:
2828
# Keep container running so we can exec into it
2929
command: ["sleep", "infinity"]
3030
depends_on:
31-
- torch-proxy
32-
- fhir-pseudonymizer
33-
- fhir-flattener
34-
- blaze-fhir
35-
- minio
31+
torch-proxy:
32+
condition: service_healthy
33+
fhir-pseudonymizer:
34+
condition: service_healthy
35+
fhir-flattener:
36+
condition: service_healthy
37+
blaze-fhir:
38+
condition: service_healthy
39+
minio:
40+
condition: service_healthy
41+
minio-init:
42+
condition: service_completed_successfully

.github/test/minio/compose.yaml

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,28 @@
11
name: minio
22

33
services:
4-
# MinIO S3-compatible object store for S3 upload E2E testing
4+
# MinIO S3-compatible object store for S3 upload E2E testing.
5+
# Starts the server, creates the test bucket, then stays running.
56
minio:
67
image: minio/minio:RELEASE.2025-01-20T14-49-07Z
78
ports: [ ":9000", ":9001" ]
89
networks: [ "aether" ]
910
environment:
1011
MINIO_ROOT_USER: minioadmin
1112
MINIO_ROOT_PASSWORD: minioadmin
12-
command: server /data --console-address ":9001"
13+
entrypoint:
14+
- /bin/sh
15+
- -c
16+
- |
17+
minio server /data --console-address ":9001" &
18+
until mc ready local 2>/dev/null; do sleep 1; done
19+
mc alias set local http://localhost:9000 minioadmin minioadmin
20+
mc mb --ignore-existing local/aether-test
21+
echo "Bucket aether-test created"
22+
wait
1323
healthcheck:
1424
test: [ "CMD", "mc", "ready", "local" ]
1525
interval: 5s
1626
timeout: 5s
1727
retries: 5
1828
start_period: 10s
19-
20-
# Init container that creates the test bucket on startup
21-
minio-init:
22-
image: minio/mc:RELEASE.2025-01-17T23-25-50Z
23-
networks: [ "aether" ]
24-
depends_on:
25-
minio:
26-
condition: service_healthy
27-
entrypoint: >
28-
/bin/sh -c "
29-
mc alias set local http://minio:9000 minioadmin minioadmin &&
30-
mc mb --ignore-existing local/aether-test &&
31-
echo 'Bucket aether-test created'
32-
"

0 commit comments

Comments
 (0)