Skip to content

Commit 56cab79

Browse files
committed
added missing unsubscribe and closing of side nav on second click
1 parent 737b7c9 commit 56cab79

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

src/app/modules/feasibility-query/components/search/search.component.ts

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ export class FeasibilityQuerySearchComponent implements OnInit, OnDestroy, After
4444

4545
elasticSearchEnabled = false;
4646

47+
listIetmDetailsSubscription: Subscription;
48+
4749
selectedDetails$: Observable<SearchTermDetails>;
4850

4951
searchFilters$: Observable<SearchFilter[]> = of([]);
@@ -93,6 +95,7 @@ export class FeasibilityQuerySearchComponent implements OnInit, OnDestroy, After
9395
this.subscription?.unsubscribe();
9496
this.searchSubscription?.unsubscribe();
9597
this.searchWithFilterSubscription?.unsubscribe();
98+
this.listIetmDetailsSubscription?.unsubscribe();
9699
}
97100

98101
/** Search Result Handling */
@@ -154,9 +157,14 @@ export class FeasibilityQuerySearchComponent implements OnInit, OnDestroy, After
154157

155158
public setClickedRow(row: InterfaceTableDataRow) {
156159
const originalEntry = row.originalEntry as CriteriaListEntry;
157-
this.searchTermDetailsService
158-
.getDetailsForListItem(originalEntry.getId())
159-
.subscribe(() => this.openSidenav());
160+
this.listIetmDetailsSubscription?.unsubscribe();
161+
if (this.isOpen) {
162+
this.closeSidenav();
163+
} else {
164+
this.listIetmDetailsSubscription = this.searchTermDetailsService
165+
.getDetailsForListItem(originalEntry.getId())
166+
.subscribe(() => this.openSidenav());
167+
}
160168
}
161169

162170
public getElasticSearchFilter(): void {

0 commit comments

Comments
 (0)