comment about moving error

Author: willbouch

integration-tests/http/__tests__/product-option/product-option.spec.ts

@@ -242,6 +242,22 @@ medusaIntegrationTestRunner({
           })
         )
       })
+
+      it("should throw when trying to update an option that does not exist", async () => {
+        const error = await api.post(
+          `/admin/product-options/iDontExist`,
+          {
+            is_exclusive: false,
+          },
+          adminHeaders
+        ).catch((e) => e)
+
+        expect(error.response.status).toEqual(404)
+        expect(error.response.data).toEqual({
+          message:  "Product option with id \"iDontExist\" not found",
+          type: "not_found"
+        })
+      })
     })
 
     describe("DELETE /admin/product-options/[id]", () => {

packages/core/core-flows/src/product/steps/update-product-options.ts

@@ -4,6 +4,7 @@ import type {
 } from "@medusajs/framework/types"
 import {
   getSelectsAndRelationsFromObjectArray,
+  MedusaError,
   Modules,
 } from "@medusajs/framework/utils"
 import { createStep, StepResponse } from "@medusajs/framework/workflows-sdk"
@@ -49,6 +50,13 @@ export const updateProductOptionsStep = createStep(
       relations: ["values"],
     })
 
+    if (!prevData.length) {
+      throw new MedusaError(
+        MedusaError.Types.NOT_FOUND,
+        `Product option with id "${data.selector.id}" not found`
+      )
+    }
+
     const productOptions = await service.updateProductOptions(
       data.selector,
       data.update

packages/medusa/src/api/admin/product-options/[id]/route.ts

@@ -12,10 +12,7 @@ import {
   AdminUpdateProductOptionType,
 } from "../validators"
 import { HttpTypes } from "@medusajs/framework/types"
-import {
-  ContainerRegistrationKeys,
-  MedusaError,
-} from "@medusajs/framework/utils"
+import { ContainerRegistrationKeys } from "@medusajs/framework/utils"
 
 export const GET = async (
   req: AuthenticatedMedusaRequest<AdminGetProductOptionParamsType>,
@@ -37,29 +34,14 @@ export const POST = async (
   req: AuthenticatedMedusaRequest<AdminUpdateProductOptionType>,
   res: MedusaResponse<HttpTypes.AdminProductOptionResponse>
 ) => {
-  const query = req.scope.resolve(ContainerRegistrationKeys.QUERY)
-  const {
-    data: [existingProductOption],
-  } = await query.graph({
-    entity: "product_option",
-    filters: { id: req.params.id },
-    fields: ["id"],
-  })
-
-  if (!existingProductOption) {
-    throw new MedusaError(
-      MedusaError.Types.NOT_FOUND,
-      `Product option with id "${req.params.id}" not found`
-    )
-  }
-
   const { result } = await updateProductOptionsWorkflow(req.scope).run({
     input: {
       selector: { id: req.params.id },
       update: req.validatedBody,
     },
   })
 
+  const query = req.scope.resolve(ContainerRegistrationKeys.QUERY)
   const {
     data: [product_option],
   } = await query.graph({