pr comments

Author: willbouch

integration-tests/http/__tests__/product-option/product-option.spec.ts

@@ -162,6 +162,7 @@ medusaIntegrationTestRunner({
         )
 
         expect(res.status).toEqual(200)
+        expect(res.data.product_option.values.length).toEqual(3)
         expect(res.data.product_option).toEqual(
           expect.objectContaining({
             title: "option1",
@@ -188,6 +189,7 @@ medusaIntegrationTestRunner({
           )
         ).data.product_option
 
+        expect(option.values.length).toEqual(2)
         expect(option).toEqual(
           expect.objectContaining({
             title: "option2",
@@ -222,6 +224,7 @@ medusaIntegrationTestRunner({
           )
         ).data.product_option
 
+        expect(option.values.length).toEqual(2)
         expect(option).toEqual(
           expect.objectContaining({
             title: "option2",

packages/core/core-flows/src/product/steps/process-product-options-for-import.ts

@@ -36,7 +36,7 @@ export const processProductOptionsForImportStep = createStep(
     const processedProducts: UpdateProductWorkflowInputDTO[] = []
 
     for (const product of data.products) {
-      if (product.options && product.options.length > 0) {
+      if (product.options?.length) {
         const createdOptions = await productService.createProductOptions(
           product.options
         )