fix: empty array handling

Author: VariableVic

src/app/api/products/route.ts

@@ -54,8 +54,6 @@ async function getProductsByCollectionId(queryParams: Record<string, any>) {
 
   const products = data.map((c) => c.products).flat() as ProductDTO[]
 
-  if (!products) return []
-
   const publishedProducts = filterPublishedProducts(products)
 
   const count = publishedProducts.length
@@ -78,6 +76,7 @@ async function getProductsByCollectionId(queryParams: Record<string, any>) {
 
 async function getProducts(params: Record<string, any>) {
   const productService = await initializeProductModule()
+
   const { id, limit, offset, cart_id } = params
 
   const filters = {} as FilterableProductProps
@@ -93,10 +92,6 @@ async function getProducts(params: Record<string, any>) {
     withDeleted: false,
   })
 
-  if (!data) {
-    return []
-  }
-
   const publishedProducts = filterPublishedProducts(data)
 
   const productsWithPrices = await getPrices(publishedProducts, cart_id)

src/lib/util/get-product-prices.ts

@@ -6,9 +6,9 @@ import { ProductDTO, ProductVariantDTO } from "@medusajs/types/dist/product"
  * @param data Array of product objects (with variants) to get prices for
  * @param cartId (Optional) cart id to get region-specific prices
  */
-export default async function getVariants(data: ProductDTO[], cartId?: string) {
+export default async function getPrices(data: ProductDTO[], cartId?: string) {
   if (!data || !data.length) {
-    throw new Error("No products provided")
+    return []
   }
 
   // Map of variant id to variant object