disable add to cart when no variant #124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The add to cart button doesn't do anything when there is no variant selected which makes sense because you need to pick a size when buying a sweatshirt. However the button looks like it's an active button and looks like it's being clicked. This change makes the UI reflect the underlying reality of the button not doing anything. Note that I'm brand new to Medusa and e-commerce in general, I won't be offended if I'm told I'm off base. For example, perhaps there are products that don't have variants, what happens then? Given that the seed data has variants this provides for a better first time experience but perhaps isn't fully correct.
|
@burbma is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
|
@VariableVic can we get some help here on merging this, thanks |
|
merge this! |
|
Thanks for the contribution! I apologize for the very late response. It looks like this component was refactored and the problem does not exist anymore. Will be closing the PR for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add to cart button doesn't do anything when there is no variant selected which makes sense because you need to pick a size when buying a sweatshirt. However the button looks like it's an active button and looks like it's being clicked. This change makes the UI reflect the underlying reality of the button not doing anything.
Note that I'm brand new to Medusa and e-commerce in general, I won't be offended if I'm told I'm off base. For example, perhaps there are products that don't have variants, what happens then? Given that the seed data has variants this provides for a better first time experience but perhaps isn't fully correct.