Centralise the store name in store.config.json #258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SharadKumar is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
|
New to Medusa, but I didnt see GET store info in Store API, it is only available in Admin API. Therefore proposed this from config. |
|
Thanks for the contribution. Sorry for the very late reply. This PR is stale so I will be closing it for now. Feel free to re-open after fixing the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Medusa Storeis hard-coded in templates all over and it would be better to centralise it instore.config.jsoninstead. This will allow developers to quickly use their store name without modifying templates and keeping in sync upstream.