Skip to content

Conversation

zaaakher
Copy link
Contributor

@zaaakher zaaakher commented Dec 5, 2024

When my shipping method is $30 for instance, It was $30,00 and this PR fixes it to $30.00

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-starter-medusa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:41pm
storefront-v2-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:41pm

Copy link

vercel bot commented Dec 5, 2024

@zaaakher is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@VariableVic VariableVic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since convertToLocale handles this region-specific logic, we don't need both replace() functions anymore. They're likely leftovers from an earlier version. Could you remove them? I'll merge it in once that's done!

@zaaakher
Copy link
Contributor Author

@VariableVic Sorry totally missed the notification. I just pushed a commit removing both replace functions

@willbouch
Copy link
Contributor

Thanks for the contribution

@willbouch willbouch merged commit c647213 into medusajs:main Aug 25, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants