Skip to content

🐛 Fix Billing Address and Controlled input bug #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

🐛 Fix Billing Address and Controlled input bug #478

wants to merge 3 commits into from

Conversation

Youssefrabei-dev
Copy link

  • the phone input was missing and fixed its file tree
  • some input fields broke on selecting a saved address on checkout now both works

@vercel Vercel
Copy link

vercel bot commented Mar 21, 2025

@YoussefRabeiii is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Mar 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storefront-v2-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 0:06am

VariableVic
VariableVic suggested changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@VariableVic VariableVic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for your contribution! Left a couple of nits, please address those and I'll merge this.

@Youssefrabei-dev
Copy link
Author

Youssefrabei-dev commented Mar 26, 2025 •
edited
Loading

i deleted the 2 files (and i think we should add the package-lock.json to the .gitignore) and i edited the typo in phone @VariableVic

@Youssefrabei-dev
Copy link
Author

@VariableVic how is the new updates going
tell me if there is anything i should edit for a successful merge

VariableVic
VariableVic suggested changes May 6, 2025
View reviewed changes
Copy link
Contributor

@VariableVic VariableVic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Youssefrabei-dev thanks for the updates. However, it seems like you completely deleted yarn.lock from the repo now. Please restore the latest yarn.lock from main, (e.g. git checkout main -- yarn.lock).

No lockfiles should be altered by this pr, as we're not touching any packages.

@willbouch
Copy link
Contributor

@Youssefrabei-dev will close the PR for now considering the last activity was a few months ago. Feel free to re-open and tag me 👍

@willbouch willbouch closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@VariableVic VariableVic VariableVic requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Youssefrabei-dev @willbouch @VariableVic @YoussefRabeiii