CV2-6689: Deprecate Slack authentication (#2416)

* CV2-6689: Remove slack auth

* CV2-6689: fix tests 1/2

* CV2-6689: fix tests 2/2

* CV2-6689: Apply PR comments

* CV2-6689: apply PR comments

Author: melsawy

Gemfile

@@ -49,9 +49,7 @@ gem 'devise', '~> 4.8'
 gem 'devise-i18n', '~> 1.10.0'
 gem 'devise-two-factor', '~> 4.0.2'
 gem 'devise_invitable', '~> 2.0'
-gem 'omniauth-twitter'
 gem 'omniauth-facebook'
-gem 'omniauth-slack'
 gem 'elasticsearch', '7.10.1'
 gem 'elasticsearch-api', '7.10.1'
 gem 'elasticsearch-transport', '7.10.1'

Gemfile.lock

@@ -457,7 +457,6 @@ GEM
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
     numerizer (0.1.1)
-    oauth (0.5.8)
     oauth2 (1.4.9)
       faraday (>= 0.17.3, < 3.0)
       jwt (>= 1.0, < 3.0)
@@ -469,17 +468,9 @@ GEM
       rack (>= 1.6.2, < 3)
     omniauth-facebook (9.0.0)
       omniauth-oauth2 (~> 1.2)
-    omniauth-oauth (1.2.0)
-      oauth
-      omniauth (>= 1.0, < 3)
     omniauth-oauth2 (1.3.1)
       oauth2 (~> 1.0)
       omniauth (~> 1.2)
-    omniauth-slack (2.3.0)
-      omniauth-oauth2 (~> 1.3.1)
-    omniauth-twitter (1.4.0)
-      omniauth-oauth (~> 1.1)
-      rack
     open_uri_redirections (0.2.1)
     opentelemetry-api (1.1.0)
     opentelemetry-common (0.19.6)
@@ -947,8 +938,6 @@ DEPENDENCIES
   nokogiri (= 1.16.5)
   omniauth-facebook
   omniauth-google-oauth2!
-  omniauth-slack
-  omniauth-twitter
   open_uri_redirections
   opentelemetry-exporter-otlp
   opentelemetry-instrumentation-action_pack

app/controllers/api/v1/admin_controller.rb

@@ -1,14 +1,6 @@
 class Api::V1::AdminController < Api::V1::BaseApiController
   before_action :authenticate_from_token!, except: [:save_messenger_credentials_for_smooch_bot, :save_instagram_credentials_for_smooch_bot]
 
-  # GET /api/admin/user/slack?uid=:uid
-  def slack_user
-    user = User.find_with_omniauth(params[:uid].to_s, 'slack')
-    slack_account = user.accounts.where(provider: 'slack').first unless user.nil?
-    user = { token: slack_account.token } unless slack_account.nil?
-    render_user user, 'slack_uid'
-  end
-
   # GET /api/admin/smooch_bot/:bot-installation-id/authorize/messenger?token=:bot-installation-token
   def save_messenger_credentials_for_smooch_bot
     self.save_facebook_credentials_for_smooch_bot('messenger')

app/controllers/api/v1/omniauth_callbacks_controller.rb

@@ -2,7 +2,6 @@ module Api
   module V1
     class OmniauthCallbacksController < Devise::OmniauthCallbacksController
       include FacebookAuthentication
-      include SlackAuthentication
       include GoogleAuthentication
 
       before_action :store_request

app/controllers/concerns/slack_authentication.rb

@@ -51,7 +51,7 @@ def notify(event, author, recipient, assigned, message = nil)
       updated_at: updated_at,
       total_tasks: total_tasks,
       completed_tasks: completed_tasks,
-      button: I18n.t("slack.fields.view_button", **{
+      button: I18n.t("mails_notifications.assignment.view_button", **{
         type: I18n.t("activerecord.models.#{model}"), app: CheckConfig.get('app_name')
       }),
       description: description,

app/mailers/assignment_mailer.rb

@@ -180,16 +180,6 @@ def create_fields
     end
   end
 
-  def create_fields_bg(set_fields)
-    data = JSON.parse(set_fields)
-    data.each do |field_name, value|
-      next unless DynamicAnnotation::FieldInstance.where(name: field_name).exists?
-      value ||= ""
-      f = create_field(field_name, value)
-      f.save!
-    end
-  end
-
   def update_fields
     if !self.set_fields.blank? && self.json_schema.blank?
       fields = self.fields

app/models/annotations/dynamic.rb

@@ -4,7 +4,7 @@ module UserMultiAuthLogin
   extend ActiveSupport::Concern
 
   included do
-    LOGINPROVIDERS = %w[slack google_oauth2]
+    LOGINPROVIDERS = %w[google_oauth2]
 
     def self.from_omniauth(auth, current_user=nil)
       self.update_facebook_uuid(auth)
@@ -144,11 +144,7 @@ def providers
           values = []
           provider_accounts.each do |a|
             info = a.omniauth_info.dig('info')
-            if a.provider == 'slack'
-              name = "#{info['nickname']} at #{info['team']}"
-            else
-              name = info['name']
-            end
+            name = info['name']
             values << { connected: true, uid: "#{a.uid}", allow_disconnect: allow_disconnect, info: "#{provider_label}: #{name}" }
           end
           providers << { key: p, add_another: true, values: values }

app/models/concerns/user_multi_auth_login.rb

@@ -7,7 +7,6 @@ class TeamUser < ApplicationRecord
 
   validates :status, presence: true
   validates :user_id, uniqueness: { scope: :team_id, message: 'already joined this team' }
-  validate :user_is_member_in_slack_team
 
   check_settings
 
@@ -112,28 +111,6 @@ def set_role_default_value
     self.role = 'collaborator' if self.role.nil?
   end
 
-  # Validate that a Slack user is part of the team's `slack_teams` setting.
-  # The `slack_teams` should be a hash of the form:
-  # { 'Slack team 1 id' => 'Slack team 1 name', 'Slack team 2 id' => 'Slack team 2 name', ... }
-  def user_is_member_in_slack_team
-    return if self.user.nil?
-    accounts = self.user.get_social_accounts_for_login({provider: 'slack'})
-    if !self.user.nil? && !accounts.blank? && self.team.setting(:slack_teams)&.is_a?(Hash)
-      accounts_team = accounts.collect{|a| a.omniauth_info&.dig('info', 'team_id')}
-      unless (self.team.setting(:slack_teams)&.keys & accounts_team).empty?
-        # Auto-approve slack user
-        self.status = 'member'
-      else
-        params = {
-          default: "Sorry, you cannot join %{team_name} because it is restricted to members of the Slack team(s) %{teams}.",
-          team_name: self.team.name,
-          teams: self.team.setting(:slack_teams).values.join(', ')
-        }
-        errors.add(:base, I18n.t(:slack_restricted_join_to_members, **params))
-      end
-    end
-  end
-
   def update_user_cached_teams_after_save
     if self.status == 'member'
       self.update_user_cached_teams(:add)

app/models/team_user.rb

@@ -31,7 +31,7 @@ class ToSOrPrivacyPolicyReadError < StandardError; end
   has_many :explainers
 
   devise :recoverable, :rememberable, :trackable, :validatable, :confirmable,
-         :omniauthable, omniauth_providers: [:twitter, :facebook, :slack, :google_oauth2]
+         :omniauthable, omniauth_providers: [:facebook, :google_oauth2]
 
   before_create :skip_confirmation_for_non_email_provider, :set_last_received_terms_email_at
   after_create :create_source_and_account, :set_source_image