Skip to content

Commit 2971563

Browse files
committed
Use simpler approach to skip previously-removed mathtext tests.
Just pytest.skip()ping them in the baseline_images fixture will avoid having to duplicate the logic in the upcoming png-only tests.
1 parent 5417682 commit 2971563

File tree

1 file changed

+15
-20
lines changed

1 file changed

+15
-20
lines changed

lib/matplotlib/tests/test_mathtext.py

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -165,42 +165,37 @@
165165
for set in chars:
166166
font_tests.append(wrapper % set)
167167

168-
font_tests = list(filter(lambda x: x[1] is not None, enumerate(font_tests)))
169-
170168

171169
@pytest.fixture
172-
def baseline_images(request, fontset, index):
170+
def baseline_images(request, fontset, index, text):
171+
if text is None:
172+
pytest.skip("test has been removed")
173173
return ['%s_%s_%02d' % (request.param, fontset, index)]
174174

175175

176-
cur_math_tests = list(filter(lambda x: x[1] is not None, enumerate(math_tests)))
177-
178-
179-
@pytest.mark.parametrize('index, test', cur_math_tests,
180-
ids=[str(index) for index, _ in cur_math_tests])
181-
@pytest.mark.parametrize('fontset',
182-
['cm', 'stix', 'stixsans', 'dejavusans',
183-
'dejavuserif'])
176+
@pytest.mark.parametrize(
177+
'index, text', enumerate(math_tests), ids=range(len(math_tests)))
178+
@pytest.mark.parametrize(
179+
'fontset', ['cm', 'stix', 'stixsans', 'dejavusans', 'dejavuserif'])
184180
@pytest.mark.parametrize('baseline_images', ['mathtext'], indirect=True)
185181
@image_comparison(baseline_images=None)
186-
def test_mathtext_rendering(baseline_images, fontset, index, test):
182+
def test_mathtext_rendering(baseline_images, fontset, index, text):
187183
mpl.rcParams['mathtext.fontset'] = fontset
188184
fig = plt.figure(figsize=(5.25, 0.75))
189-
fig.text(0.5, 0.5, test,
185+
fig.text(0.5, 0.5, text,
190186
horizontalalignment='center', verticalalignment='center')
191187

192188

193-
@pytest.mark.parametrize('index, test', font_tests,
194-
ids=[str(index) for index, _ in font_tests])
195-
@pytest.mark.parametrize('fontset',
196-
['cm', 'stix', 'stixsans', 'dejavusans',
197-
'dejavuserif'])
189+
@pytest.mark.parametrize(
190+
'index, text', enumerate(font_tests), ids=range(len(font_tests)))
191+
@pytest.mark.parametrize(
192+
'fontset', ['cm', 'stix', 'stixsans', 'dejavusans', 'dejavuserif'])
198193
@pytest.mark.parametrize('baseline_images', ['mathfont'], indirect=True)
199194
@image_comparison(baseline_images=None, extensions=['png'])
200-
def test_mathfont_rendering(baseline_images, fontset, index, test):
195+
def test_mathfont_rendering(baseline_images, fontset, index, text):
201196
mpl.rcParams['mathtext.fontset'] = fontset
202197
fig = plt.figure(figsize=(5.25, 0.75))
203-
fig.text(0.5, 0.5, test,
198+
fig.text(0.5, 0.5, text,
204199
horizontalalignment='center', verticalalignment='center')
205200

206201

0 commit comments

Comments
 (0)