Merge pull request matplotlib#8987 from z0rgy/patch-2

Tick formatter does not support grouping with locale

Author: jklymak

.coveragerc

@@ -7,6 +7,7 @@ omit = matplotlib/_version.py
 
 [report]
 exclude_lines =
+    pragma: no cover
     raise NotImplemented
     def __str__
     def __repr__

doc/api/next_api_changes/behavior/8987-Z.rst

@@ -0,0 +1,6 @@
+``ScalarFormatter`` *useLocale* option obeys grouping
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+When the `~.ScalarFormatter` option *useLocale* is enabled (or
+:rc:`axes.formatter.use_locale` is *True*) and the configured locale uses
+grouping, a separator will be added as described in `locale.format_string`.

lib/matplotlib/tests/test_ticker.py

@@ -1,6 +1,7 @@
 from contextlib import nullcontext
-import re
 import itertools
+import locale
+import re
 
 import numpy as np
 from numpy.testing import assert_almost_equal, assert_array_equal
@@ -546,6 +547,21 @@ def test_use_offset(self, use_offset):
             tmp_form = mticker.ScalarFormatter()
             assert use_offset == tmp_form.get_useOffset()
 
+    def test_use_locale(self):
+        conv = locale.localeconv()
+        sep = conv['thousands_sep']
+        if not sep or conv['grouping'][-1:] in ([], [locale.CHAR_MAX]):
+            pytest.skip('Locale does not apply grouping')  # pragma: no cover
+
+        with mpl.rc_context({'axes.formatter.use_locale': True}):
+            tmp_form = mticker.ScalarFormatter()
+            assert tmp_form.get_useLocale()
+
+            tmp_form.create_dummy_axis()
+            tmp_form.set_bounds(0, 10)
+            tmp_form.set_locs([1, 2, 3])
+            assert sep in tmp_form(1e9)
+
     @pytest.mark.parametrize(
         'sci_type, scilimits, lim, orderOfMag, fewticks', scilimits_data)
     def test_scilimits(self, sci_type, scilimits, lim, orderOfMag, fewticks):

lib/matplotlib/ticker.py

@@ -612,7 +612,7 @@ def _format_maybe_minus_and_locale(self, fmt, arg):
         """
         Format *arg* with *fmt*, applying unicode minus and locale if desired.
         """
-        return self.fix_minus(locale.format_string(fmt, (arg,))
+        return self.fix_minus(locale.format_string(fmt, (arg,), True)
                               if self._useLocale else fmt % arg)
 
     def get_useMathText(self):