Merge pull request matplotlib#20438 from QuLogic/fix-tickdir-deprecation

Fix deprecation of `Tick.apply_tickdir`.

Author: jklymak

lib/matplotlib/axis.py

@@ -211,7 +211,7 @@ def _apply_tickdir(self, tickdir):
 
     @_api.deprecated("3.5", alternative="axis.set_tick_params")
     def apply_tickdir(self, tickdir):
-        self._apply_tickdir()
+        self._apply_tickdir(tickdir)
         self.stale = True
 
     def get_tickdir(self):

lib/matplotlib/tests/test_axes.py

@@ -5771,6 +5771,24 @@ def test_pandas_bar_align_center(pd):
     fig.canvas.draw()
 
 
+def test_tick_apply_tickdir_deprecation():
+    # Remove this test when the deprecation expires.
+    import matplotlib.axis as maxis
+    ax = plt.axes()
+
+    tick = maxis.XTick(ax, 0)
+    with pytest.warns(MatplotlibDeprecationWarning,
+                      match="The apply_tickdir function was deprecated in "
+                            "Matplotlib 3.5"):
+        tick.apply_tickdir('out')
+
+    tick = maxis.YTick(ax, 0)
+    with pytest.warns(MatplotlibDeprecationWarning,
+                      match="The apply_tickdir function was deprecated in "
+                            "Matplotlib 3.5"):
+        tick.apply_tickdir('out')
+
+
 def test_axis_set_tick_params_labelsize_labelcolor():
     # Tests fix for issue 4346
     axis_1 = plt.subplot()