Move some checks from RendererAgg wrapper into itself

Author: QuLogic

src/_backend_agg.cpp

@@ -29,6 +29,16 @@ RendererAgg::RendererAgg(unsigned int width, unsigned int height, double dpi)
       lastclippath(NULL),
       _fill_color(agg::rgba(1, 1, 1, 0))
 {
+    if (dpi <= 0.0) {
+        throw std::range_error("dpi must be positive");
+    }
+
+    if (width >= 1 << 16 || height >= 1 << 16) {
+        throw std::range_error(
+            "Image size of " + std::to_string(width) + "x" + std::to_string(height) +
+            " pixels is too large. It must be less than 2^16 in each direction.");
+    }
+
     unsigned stride(width * 4);
 
     pixBuffer = new agg::int8u[NUMBYTES];

src/_backend_agg.h

@@ -6,6 +6,8 @@
 #ifndef MPL_BACKEND_AGG_H
 #define MPL_BACKEND_AGG_H
 
+#include <pybind11/pybind11.h>
+
 #include <cmath>
 #include <algorithm>
 
@@ -40,6 +42,8 @@
 #include "array.h"
 #include "agg_workaround.h"
 
+namespace py = pybind11;
+
 /**********************************************************************/
 
 // a helper class to pass agg::buffer objects around.
@@ -1226,6 +1230,19 @@ inline void RendererAgg::draw_gouraud_triangles(GCAgg &gc,
                                                 ColorArray &colors,
                                                 agg::trans_affine &trans)
 {
+    if (points.shape(0) && !check_trailing_shape(points, "points", 3, 2)) {
+        throw py::error_already_set();
+    }
+    if (colors.shape(0) && !check_trailing_shape(colors, "colors", 3, 4)) {
+        throw py::error_already_set();
+    }
+    if (points.shape(0) != colors.shape(0)) {
+        throw py::value_error(
+            "points and colors arrays must be the same length, got " +
+            std::to_string(points.shape(0)) + " points and " +
+            std::to_string(colors.shape(0)) + "colors");
+    }
+
     theRasterizer.reset_clipping();
     rendererBase.reset_clipping(true);
     set_clipbox(gc.cliprect, theRasterizer);

src/_backend_agg_wrapper.cpp

@@ -145,20 +145,6 @@ static int PyRendererAgg_init(PyRendererAgg *self, PyObject *args, PyObject *kwd
         return -1;
     }
 
-    if (dpi <= 0.0) {
-        PyErr_SetString(PyExc_ValueError, "dpi must be positive");
-        return -1;
-    }
-
-    if (width >= 1 << 16 || height >= 1 << 16) {
-        PyErr_Format(
-            PyExc_ValueError,
-            "Image size of %dx%d pixels is too large. "
-            "It must be less than 2^16 in each direction.",
-            width, height);
-        return -1;
-    }
-
     CALL_CPP_INIT("RendererAgg", self->x = new RendererAgg(width, height, dpi))
 
     return 0;
@@ -420,19 +406,6 @@ PyRendererAgg_draw_gouraud_triangles(PyRendererAgg *self, PyObject *args)
                           &trans)) {
         return NULL;
     }
-    if (points.shape(0) && !check_trailing_shape(points, "points", 3, 2)) {
-        return NULL;
-    }
-    if (colors.shape(0) && !check_trailing_shape(colors, "colors", 3, 4)) {
-        return NULL;
-    }
-    if (points.shape(0) != colors.shape(0)) {
-        PyErr_Format(PyExc_ValueError,
-                     "points and colors arrays must be the same length, got "
-                     "%" NPY_INTP_FMT " points and %" NPY_INTP_FMT "colors",
-                     points.shape(0), colors.shape(0));
-        return NULL;
-    }
 
     CALL_CPP("draw_gouraud_triangles", self->x->draw_gouraud_triangles(gc, points, colors, trans));
 

src/meson.build

@@ -77,7 +77,7 @@ extension_data = {
       '_backend_agg.cpp',
       '_backend_agg_wrapper.cpp',
     ),
-    'dependencies': [agg_dep, numpy_dep, freetype_dep],
+    'dependencies': [agg_dep, numpy_dep, freetype_dep, pybind11_dep],
   },
   '_c_internal_utils': {
     'subdir': 'matplotlib',

src/py_exceptions.h

@@ -46,9 +46,17 @@ class exception : public std::exception
         }                                                                    \
         return (errorcode);                                                  \
     }                                                                        \
+    catch (const std::range_error &e)                                        \
+    {                                                                        \
+        PyErr_Format(PyExc_ValueError, "In %s: %s", (name), e.what());       \
+        {                                                                    \
+            cleanup;                                                         \
+        }                                                                    \
+        return (errorcode);                                                  \
+    }                                                                        \
     catch (const std::runtime_error &e)                                      \
     {                                                                        \
-        PyErr_Format(PyExc_RuntimeError, "In %s: %s", (name), e.what());    \
+        PyErr_Format(PyExc_RuntimeError, "In %s: %s", (name), e.what());     \
         {                                                                    \
             cleanup;                                                         \
         }                                                                    \