Merge pull request matplotlib#14930 from joelfrederico/macos-common-icon

Set Dock icon on the macosx backend

Author: dstansby

lib/matplotlib/backends/backend_macosx.py

@@ -67,6 +67,8 @@ class FigureManagerMac(_macosx.FigureManager, FigureManagerBase):
     """
     def __init__(self, canvas, num):
         _macosx.FigureManager.__init__(self, canvas)
+        icon_path = str(cbook._get_data_path('images/matplotlib.pdf'))
+        _macosx.FigureManager.set_icon(icon_path)
         FigureManagerBase.__init__(self, canvas, num)
         if mpl.rcParams['toolbar'] == 'toolbar2':
             self.toolbar = NavigationToolbar2Mac(canvas)

src/_macosx.m

@@ -697,6 +697,45 @@ static CGFloat _get_device_scale(CGContextRef cr)
     Py_RETURN_NONE;
 }
 
+static PyObject*
+FigureManager_set_icon(PyObject* null, PyObject* args) {
+    PyObject* icon_path;
+    if (!PyArg_ParseTuple(args, "O&", &PyUnicode_FSDecoder, &icon_path)) {
+	return NULL;
+    }
+    const char* icon_path_ptr = PyUnicode_AsUTF8(icon_path);
+    if (!icon_path_ptr) {
+        Py_DECREF(icon_path);
+        return NULL;
+    }
+    @autoreleasepool {
+        NSString* ns_icon_path = [NSString stringWithUTF8String: icon_path_ptr];
+	Py_DECREF(icon_path);
+        if (!ns_icon_path) {
+            PyErr_SetString(PyExc_RuntimeError, "Could not convert to NSString*");
+            return NULL;
+        }
+        NSImage* image = [[[NSImage alloc] initByReferencingFile: ns_icon_path] autorelease];
+        if (!image) {
+            PyErr_SetString(PyExc_RuntimeError, "Could not create NSImage*");
+            return NULL;
+        }
+        if (!image.valid) {
+            PyErr_SetString(PyExc_RuntimeError, "Image is not valid");
+            return NULL;
+        }
+	@try {
+	  NSApplication* app = [NSApplication sharedApplication];
+	  app.applicationIconImage = image;
+	}
+	@catch (NSException* exception) {
+	    PyErr_SetString(PyExc_RuntimeError, exception.reason.UTF8String);
+	    return NULL;
+	}
+    }
+    Py_RETURN_NONE;
+}
+
 static PyObject*
 FigureManager_set_window_title(FigureManager* self,
                                PyObject *args, PyObject *kwds)
@@ -769,6 +808,10 @@ static CGFloat _get_device_scale(CGContextRef cr)
         {"destroy",
          (PyCFunction)FigureManager_destroy,
          METH_NOARGS},
+	{"set_icon",
+    	 (PyCFunction)FigureManager_set_icon,
+    	 METH_STATIC | METH_VARARGS,
+	 "Set application icon"},
         {"set_window_title",
          (PyCFunction)FigureManager_set_window_title,
          METH_VARARGS},