Skip to content

Commit b9f9fec

Browse files
committed
Deprecate project argument to Line3DCollection.draw.
1 parent 2219872 commit b9f9fec

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

doc/api/next_api_changes/deprecations/18302-ES.rst

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,15 @@ now deprecated:
1212
These attributes are all available via `.Axes3D`, which can be accessed via
1313
``self.axes`` on all `.Artist`\s.
1414

15-
``renderer`` argument of ``do_3d_projection`` method for ``Collection3D``/``Patch3D``
16-
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
15+
*renderer* argument of ``do_3d_projection`` method for ``Collection3D``/``Patch3D``
16+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1717

18-
The ``renderer`` argument for the ``do_3d_projection`` method on
19-
``Collection3D`` and ``Patch3D`` is no longer necessary, and passing it during
20-
draw is deprecated.
18+
The *renderer* argument for the ``do_3d_projection`` method on ``Collection3D``
19+
and ``Patch3D`` is no longer necessary, and passing it during draw is
20+
deprecated.
21+
22+
*project* argument of ``draw`` method for ``Line3DCollection``
23+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
24+
25+
The *project* argument for the ``draw`` method on ``Line3DCollection`` is
26+
deprecated. Call `.Line3DCollection.do_3d_projection` explicitly instead.

lib/mpl_toolkits/mplot3d/art3d.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,8 @@ def do_3d_projection(self, renderer=None):
316316
return minz
317317

318318
@artist.allow_rasterization
319+
@_api.delete_parameter('3.4', 'project',
320+
alternative='Line3DCollection.do_3d_projection')
319321
def draw(self, renderer, project=False):
320322
if project:
321323
self.do_3d_projection()

lib/mpl_toolkits/mplot3d/axis3d.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,8 @@ def draw(self, renderer):
357357
self.gridlines.set_color(info['grid']['color'])
358358
self.gridlines.set_linewidth(info['grid']['linewidth'])
359359
self.gridlines.set_linestyle(info['grid']['linestyle'])
360-
self.gridlines.draw(renderer, project=True)
360+
self.gridlines.do_3d_projection()
361+
self.gridlines.draw(renderer)
361362

362363
# Draw ticks
363364
tickdir = info['tickdir']

0 commit comments

Comments
 (0)